Skip to content

Commit

Permalink
[feat] Support PUPPETEER_SKIP_CHROMIUM_DOWNLOAD in npmrc
Browse files Browse the repository at this point in the history
This patch adds support for PUPPETEER_SKIP_CHROMIUM_DOWNLOAD
variable in npm config.

This aligns the variable with the rest of supported environment variables.
  • Loading branch information
gordomium authored and aslushnikov committed Sep 26, 2017
1 parent 45f2640 commit 2babcb0
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion docs/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ Puppeteer is a Node library which provides a high-level API to control Chromium
Puppeteer looks for certain [environment variables](https://en.wikipedia.org/wiki/Environment_variable) to aid its operations:

- `HTTP_PROXY`, `HTTPS_PROXY`, `NO_PROXY` - defines HTTP proxy settings that are used to download and run Chromium.
- `PUPPETEER_SKIP_CHROMIUM_DOWNLOAD` - do not download bundled Chromium during installation step.
- `PUPPETEER_SKIP_CHROMIUM_DOWNLOAD` - do not download bundled Chromium during installation step. (`puppeteer_skip_chromium_download` in `.npmrc` as same)
### class: Puppeteer

Puppeteer module provides a method to launch a Chromium instance.
Expand Down
4 changes: 4 additions & 0 deletions install.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ if (process.env.PUPPETEER_SKIP_CHROMIUM_DOWNLOAD) {
console.log('**INFO** Skipping Chromium download. "PUPPETEER_SKIP_CHROMIUM_DOWNLOAD" environment variable was found.');
return;
}
if (process.env.NPM_CONFIG_PUPPETEER_SKIP_CHROMIUM_DOWNLOAD || process.env.npm_config_puppeteer_skip_chromium_download) {
console.log('**INFO** Skipping Chromium download. "PUPPETEER_SKIP_CHROMIUM_DOWNLOAD" was set in npm config.');
return;
}

const Downloader = require('./utils/ChromiumDownloader');
const platform = Downloader.currentPlatform();
Expand Down

0 comments on commit 2babcb0

Please sign in to comment.