Adds rule BigIntegerInstantiation in pmd-ruleset (getodk#1447)

neilong31 · Sep 11, 2017 · bd62470 · bd62470
1 parent 5c01b09
commit bd62470
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/collect_app/src/main/java/org/odk/collect/android/widgets/RangeWidget.java b/collect_app/src/main/java/org/odk/collect/android/widgets/RangeWidget.java
@@ -216,7 +216,7 @@ private void disableWidget() {
 
     private boolean isWidgetValid() {
         boolean result = true;
-        if (rangeStep.compareTo(new BigDecimal(0)) == 0 || rangeEnd.subtract(rangeStart).remainder(rangeStep).compareTo(new BigDecimal(0)) != 0) {
+        if (rangeStep.compareTo(BigDecimal.ZERO) == 0 || rangeEnd.subtract(rangeStart).remainder(rangeStep).compareTo(BigDecimal.ZERO) != 0) {
             disableWidget();
             result = false;
         }

diff --git a/config/quality/pmd/pmd-ruleset.xml b/config/quality/pmd/pmd-ruleset.xml
@@ -47,7 +47,6 @@
         <exclude name="AvoidStringBufferField" />
     </rule>
     <rule ref="rulesets/java/basic.xml">
-        <exclude name="BigIntegerInstantiation" />
         <exclude name="DontUseFloatTypeForLoopIndices" />
         <exclude name="CollapsibleIfStatements" />
         <exclude name="SimplifiedTernary" />