Skip to content

Commit

Permalink
x86/microcode: Do some minor fixups
Browse files Browse the repository at this point in the history
Improve debugging printks and fixup formatting.

Signed-off-by: Borislav Petkov <[email protected]>
Reviewed-by: Ashok Raj <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
  • Loading branch information
suryasaimadhu committed Nov 2, 2022
1 parent a61ac80 commit 2e6ff40
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions arch/x86/kernel/cpu/microcode/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -568,6 +568,8 @@ static int mc_cpu_starting(unsigned int cpu)
{
enum ucode_state err = microcode_ops->apply_microcode(cpu);

pr_debug("%s: CPU%d, err: %d\n", __func__, cpu, err);

return err == UCODE_ERROR;
}

Expand All @@ -590,7 +592,7 @@ static int mc_cpu_down_prep(unsigned int cpu)

/* Suspend is in progress, only remove the interface */
sysfs_remove_group(&dev->kobj, &mc_attr_group);
pr_debug("CPU%d removed\n", cpu);
pr_debug("%s: CPU%d\n", __func__, cpu);

return 0;
}
Expand Down Expand Up @@ -639,14 +641,11 @@ static int __init microcode_init(void)
if (!microcode_ops)
return -ENODEV;

microcode_pdev = platform_device_register_simple("microcode", -1,
NULL, 0);
microcode_pdev = platform_device_register_simple("microcode", -1, NULL, 0);
if (IS_ERR(microcode_pdev))
return PTR_ERR(microcode_pdev);

error = sysfs_create_group(&cpu_subsys.dev_root->kobj,
&cpu_root_microcode_group);

error = sysfs_create_group(&cpu_subsys.dev_root->kobj, &cpu_root_microcode_group);
if (error) {
pr_err("Error creating microcode group!\n");
goto out_pdev;
Expand Down

0 comments on commit 2e6ff40

Please sign in to comment.