net/sched: act_ct: Fix skb double-free in tcf_ct_handle_fragments() e…

…rror flow tcf_ct_handle_fragments() shouldn't free the skb when ip_defrag() call fails. Otherwise, we will cause a double-free bug. In such cases, just return the error to the caller. Fixes: b57dc7c ("net/sched: Introduce action ct") Signed-off-by: Alaa Hleihel <[email protected]> Reviewed-by: Roi Dayan <[email protected]> Signed-off-by: David S. Miller <[email protected]>
nelseric · Aug 20, 2020 · eda814b · eda814b
1 parent ab921f3
commit eda814b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c
@@ -704,7 +704,7 @@ static int tcf_ct_handle_fragments(struct net *net, struct sk_buff *skb,
 		err = ip_defrag(net, skb, user);
 		local_bh_enable();
 		if (err && err != -EINPROGRESS)
-			goto out_free;
+			return err;
 
 		if (!err) {
 			*defrag = true;