[nemo-qml-plugin-contacts] Fix de-duplication error #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numbers that have no possibility of being duplicates are wrongly omitted from the result set.
|
LGTM. Surprised we haven't noticed this before.. |
|
Yeah, massive testing failure. I would add more test cases but testing based on permutations gets out of hand really quickly :( Personally, I think the ordering of inputs is most likely to cause future regressions when this function is modified, but it is a huge testing cost to pay... |
matthewvogt
added a commit
that referenced
this pull request
Jul 28, 2014
[nemo-qml-plugin-contacts] Fix de-duplication error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numbers that have no possibility of being duplicates are wrongly omitted from the result set.