[nemo-qml-plugin-contacts] Delegate the ordering of first and last names... #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes to libcontacts Centralize the logic for presenting name tokens.
| @@ -183,9 +183,6 @@ void SeasidePerson::setFirstName(const QString &name) | |||
|
|
|||
| emit firstNameChanged(); | |||
|
|
|||
| const bool firstNameFirst(SeasideCache::displayLabelOrder() == SeasideCache::FirstNameFirst); | |||
There was a problem hiding this comment.
I don't think this was previously necessary - recalculateDisplayLabel() will emit both primaryNameChanged() and secondaryNameChanged() if the display label changes, and I don't think it's possible to change either first or last name without changing the derived display label.
|
LGTM |
matthewvogt
added a commit
that referenced
this pull request
Mar 5, 2015
[nemo-qml-plugin-contacts] Delegate the ordering of first and last names...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to libcontacts
Centralize the logic for presenting name tokens.
Depends on: nemomobile/libcontacts#101