Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EOF smart contracts support #903

Merged
merged 85 commits into from
Dec 19, 2023
Merged

EOF smart contracts support #903

merged 85 commits into from
Dec 19, 2023

Conversation

ysavchenko
Copy link

No description provided.

YaroslavNekryach and others added 30 commits August 10, 2023 11:05
@YaroslavNekryach
EOF contract validation (base implementation)
59fa1a8
@faramozzayw
EOF container (base implementation)
b0ab3a1
@faramozzayw
changed function signatures
27e1c61
@faramozzayw
change Vec<u8> => Buffer
9658ab8
@faramozzayw
remove useless type cast
9c6a1dc
@YaroslavNekryach
EOF base opcode implementation
dc2150f
@faramozzayw
added base check to contract creation
8a39971
@YaroslavNekryach
Fixed UnknownOpcode in validation
b7c4a3c
@YaroslavNekryach
Merge branch 'eof/container' into eof/develop
195c58f 
# Conflicts:
#	evm_loader/program/src/error.rs
#	evm_loader/program/src/evm/eof.rs
@YaroslavNekryach
Some fixes after merge
8ee710a
@faramozzayw
update container code validation
ce4bf3a
@YaroslavNekryach
Merge branch 'eof/validation' into eof/develop
7e59886 
# Conflicts:
#	evm_loader/program/src/evm/validate.rs
@YaroslavNekryach
Fixed errors with unused fields and functions
3584833
@faramozzayw
Fixed compilation errors
9655002
@faramozzayw
opcode table improvement
301a0ce
@YaroslavNekryach
Merge pull request #3 from allbridge-io/eof/opcode-table-improvement
5ca8a92 
opcode table improvement
@faramozzayw
refactor get_u16_or_default & get_i16_or_default
36abbb3
@faramozzayw
fix
455a9ac
@faramozzayw
remove some .unwrap()
c0a2562
@YaroslavNekryach
Move validation to container
99f2bc1
@YaroslavNekryach
Merge remote-tracking branch 'origin/eof/develop' into eof/develop
d516423
@YaroslavNekryach
Call unmarshal and validation
694545d
@YaroslavNekryach
Fixed container validation in CREATE and CREATE2
7216946
@YaroslavNekryach
Fixed JUMP opcodes
df95631
@faramozzayw
fix opcode table
bd1ae38
@faramozzayw
Merge branch 'eof/develop' of github.com:allbridge-io/neon-evm into e…
345fe3b 
…of/fix_opcode
@YaroslavNekryach
Fixed JUMP destinations
22f8ddd
@faramozzayw
fix typo
b3a823a
@faramozzayw
refactor opcode_deprecated
9019e7c
@faramozzayw
Merge branch 'eof/develop' of github.com:allbridge-io/neon-evm into e…
62d22da 
…of/fix_opcode
kristinaNikolaevaa
kristinaNikolaevaa reviewed Sep 12, 2023
View reviewed changes
Copy link
Collaborator

@kristinaNikolaevaa kristinaNikolaevaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that to test this EIP, a couple of tests with deployment and interaction with the contract via execute_transaction_steps_from_account will be enough. I suggest placing these tests in a separate file. Using execute_transaction_steps_from_account will be sufficient to test the new binary format. There is no need to test all contracts currently used in tests for the new format. A eof-contract can be placed in an existing pytest.CONTRACTS_PATH directory.

YaroslavNekryach and others added 3 commits October 19, 2023 18:41
@YaroslavNekryach
Changed tests to fixture
b58c33e
@YaroslavNekryach
Merge pull request #10 from allbridge-io/eof/test
0cbec28 
Eof/test
@YaroslavNekryach
Eof/test (#11)
7d9e3cf 
* Fixed test_call_contract_function_with_neon_transfer test
@gigimon
Copy link
Contributor

gigimon commented Oct 24, 2023

@anton-lisanin I don't have questions about tests.

@afalaleev afalaleev marked this pull request as ready for review October 27, 2023 08:41
YaroslavNekryach and others added 9 commits October 30, 2023 17:15
@YaroslavNekryach
Merge remote-tracking branch 'origin/develop' into eof/develop
42510d0 
# Conflicts:
#	Dockerfile
#	evm_loader/program/src/evm/mod.rs
#	evm_loader/program/src/evm/opcode.rs
#	evm_loader/program/src/evm/opcode_table.rs
#	evm_loader/program/src/evm/stack.rs
#	tests/conftest.py
#	tests/utils/contract.py
@YaroslavNekryach
Fixes after merge
4ff80dc
@faramozzayw
fix compilation errors
b88d573
@faramozzayw
move binaries
00efd48
@faramozzayw
fix EOF opcodes
cbc3086
@faramozzayw
Merge branch 'develop' of github.com:allbridge-io/neon-evm into eof/d…
345dfd4 
…evelop-merge
@faramozzayw
added EOF opcodes to logs
5ddd560
@YaroslavNekryach
Returned deploy-test.sh
7269a63
@YaroslavNekryach
Merge pull request #12 from allbridge-io/eof/develop-merge
a103896 
EOF merge
@afalaleev
Copy link
Contributor

The CI run of PR requires the passing of secret variables.
To speed up the merge process, the CI run was performed on the alternative branch:
https://github.com/neonevm/neon-evm/actions/runs/7259133669

@afalaleev afalaleev merged commit 7bd730c into neonevm:develop Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristinaNikolaevaa kristinaNikolaevaa kristinaNikolaevaa left review comments

@gigimon gigimon gigimon approved these changes

@afalaleev afalaleev afalaleev approved these changes

@anton-lisanin anton-lisanin Awaiting requested review from anton-lisanin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ysavchenko @gigimon @afalaleev @kristinaNikolaevaa @YaroslavNekryach @faramozzayw