Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Move original backers to sponsors page. #100

Merged
merged 2 commits into from
May 27, 2015

Conversation

fwalch
Copy link
Member

@fwalch fwalch commented May 24, 2015

Maybe we should have an email address for sponsors to write to.. as it says on the page, not everybody has a GitHub account, so they can't send a pull request to update the sponsors-override file.

gui

@tarruda
Copy link
Member

tarruda commented May 24, 2015

👍

Maybe we should have an email address for sponsors to write to.. as it says on the page, not everybody has a GitHub account, so they can't send a pull request to update the sponsors-override file.

True, we can use the mailing list for that. Can you add this information?

@fwalch
Copy link
Member Author

fwalch commented May 25, 2015

Added: "If you don't have a GitHub account, you can write to the Neovim mailing list instead."

@fwalch
Copy link
Member Author

fwalch commented May 26, 2015

@tarruda uBlock doesn't seem to like (i.e. hides) elements that contain "logo" in their CSS class.. something like the following should fix that:

diff --git a/sponsor-generator/lib/sponsor.ejs b/sponsor-generator/lib/sponsor.ejs
index 45c8b48..bbb20fe 100644
--- a/sponsor-generator/lib/sponsor.ejs
+++ b/sponsor-generator/lib/sponsor.ejs
@@ -1,5 +1,5 @@
 <tr class="sponsor">
-<td class="sponsor-logo">
+<td class="sponsor-image">
   <% if (url) { %>
   <a href="<%= url %>"><img src="<%= logo %>"></img></a>
   <% } else { %>
diff --git a/sponsor-generator/lib/sponsor_front.ejs b/sponsor-generator/lib/sponsor_front.ejs
index ccfdc16..eb972f2 100644
--- a/sponsor-generator/lib/sponsor_front.ejs
+++ b/sponsor-generator/lib/sponsor_front.ejs
@@ -1,5 +1,5 @@
 <div class="sponsor-front">
-<div class="sponsor-logo">
+<div class="sponsor-image">
   <% if (url) { %>
   <a href="<%= url %>"><img src="<%= frontLogo %>" alt="Logo of <%= name %>"></img></a>
   <% } else { %>

I didn't add it as a commit here because I didn't know how to create the .js file from the ejs.

@tarruda
Copy link
Member

tarruda commented May 26, 2015

@tarruda uBlock doesn't seem to like (i.e. hides) elements that contain "logo" in their CSS class.. something like the following should fix that:

👍

I didn't add it as a commit here because I didn't know how to create the .js file from the ejs.

After installing node.js/io.js(io.js seems more stable), install gulp which is the build tool I used to bundle javascript(only need sudo if you are using a system-wide installation of node.js):

sudo npm install -g gulp

Then from the sponsor-generator directory install the dependencies and recreate the bundle:

npm install
gulp

This will leave a modified javascript file in the js directory which you can commit.

Some adblockers apparently remove elements with a CSS class that
contains the word "logo".
@fwalch
Copy link
Member Author

fwalch commented May 27, 2015

Thanks for the instructions, pushed a commit.

tarruda added a commit that referenced this pull request May 27, 2015
Move original backers to sponsors page.
@tarruda tarruda merged commit dcba125 into neovim:master May 27, 2015
@tarruda
Copy link
Member

tarruda commented May 27, 2015

Thanks

@fwalch fwalch deleted the move-backers branch May 27, 2015 12:40
@fwalch fwalch mentioned this pull request May 27, 2015
@jasonlong jasonlong mentioned this pull request May 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants