Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #14: add Kramdown via Gemfile. #16

Merged
merged 1 commit into from
Feb 25, 2014
Merged

Conversation

commonquail
Copy link
Contributor

$ sudo gem install bundle
$ bundle install
$ jekyll serve

@jbranchaud
Copy link
Contributor

@commonquail Thanks for the PR. Before I merge it, can you add a version for the kramdown dependency? Following in Jekyll's footsteps, I would suggest v1.3 like so:

gem 'kramdown', '~> 1.3'

@commonquail
Copy link
Contributor Author

Sure. Should I add Jekyll (which version?) immediately, too? I think we'll need that for Travis CI anyway.

@cweagans
Copy link
Contributor

I don't think we'll need Travis CI on this repo. All of the "builds" are handled by Github, and there's no tests to run. For now, let's just stick with Kramdown. Can you open another issue to discuss adding Jekyll to the Gemfile?

    $ sudo gem install bundle
    $ bundle install
    $ jekyll serve
@jbranchaud
Copy link
Contributor

I agree with @cweagans, there is no reason we should need Travis CI, at least not as long as this is just a GitHub pages site.

@commonquail
Copy link
Contributor Author

I don't disagree, I just saw it mentioned on the Wiki.

@jbranchaud
Copy link
Contributor

Oh I see, I believe the wiki is suggesting that we show the Travis CI build status for Neovim itself, not that we add Travis CI for this repo.

@retrohacker
Copy link
Contributor

Yes, I meant the build status of neovim, not the website.
On Feb 24, 2014 1:33 PM, "Josh Branchaud" [email protected] wrote:

Oh I see, I believe the wiki is suggesting that we show the Travis CI
build status for Neovim itself, not that we add Travis CI for this repo.

Reply to this email directly or view it on GitHubhttps://github.com//pull/16#issuecomment-35925625
.

@jbranchaud
Copy link
Contributor

@Crackerz Whoops, sorry for the misunderstanding.

cweagans added a commit that referenced this pull request Feb 25, 2014
Close #14: add Kramdown via Gemfile.
@cweagans cweagans merged commit 5f26991 into neovim:master Feb 25, 2014
@commonquail commonquail deleted the gemfile branch February 26, 2014 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants