Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color scheme support #189

Merged
merged 7 commits into from
Sep 1, 2020
Merged

Add color scheme support #189

merged 7 commits into from
Sep 1, 2020

Conversation

rockerBOO
Copy link
Contributor

Goal:

To have a darker version of the site.

Features:

  • Color scheme support.
  • Uses CSS variables to modify the colors.
  • Default color scheme is the light version.
  • Uses CSS Grid.
  • Add Calibri font to default font list.

Screens:

https://imgur.com/a/JX0AyXb

This site's source is
<a href="https://github.com/neovim/neovim.github.io/">hosted on GitHub</a
>.
</div>
Copy link
Member

@justinmk justinmk Aug 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please undo all cosmetic formatting changes so that the PR is easier to review.

Also for all of our projects we use 2-space indent, changing that just causes churn.

@justinmk
Copy link
Member

Thanks, it's great to have help with the website! If this is a small change and doesn't bloat the site size too much, I don't have an objection.

Can you show a screenshot of the docs https://neovim.io/doc/user/ ? Most of the rest of the site is not something users are likely to spend more than 5 minutes looking at, so I don't see the purpose of theming. Not to mention, the website HTML is pretty "clean" so it should be trivial for users to theme the site using a browser extension or something.

@rockerBOO
Copy link
Contributor Author

Thank you Justin!

I couldn't figure out how to get /doc/ to generate. Is there some documentation for how to do that?

My main goal was I am learning about the new LSP integration, and I am sharing particular pages with others who are also learning it. I spend maybe hours looking at the page currently. The lighter page can be tough to work with and I would rather not have to install a plugin as most websites I use have a dark version.

My vim experience is low, and also maybe realizing late, that I could use the documentation inside Neovim.


  • Didn't mean to change the formatting so I will fix that.
  • Once I know how to generate the docs pages, I will do that and clean up any inconsistencies with the styling.

@justinmk
Copy link
Member

justinmk commented Sep 1, 2020

I couldn't figure out how to get /doc/ to generate. Is there some documentation for how to do that?

You could edit the online version of https://neovim.io/doc/user/ in chrome/firefox devtools , don't need to generate the docs.

@rockerBOO
Copy link
Contributor Author

User manual
Mobile

Seems to look good to me.

Thanks Justin!

@justinmk
Copy link
Member

justinmk commented Sep 1, 2020

yeah looks pretty good. so the formatting needs to be fixed before I can actually review this...

@rockerBOO
Copy link
Contributor Author

Where is my formatting bad? I had to make changes on the modified files (removed the unmodified formatted files). Do I need to undo more formatting for those files?

@justinmk
Copy link
Member

justinmk commented Sep 1, 2020

Ok these changes actually look pretty thoughtful. Nice work.

@justinmk justinmk merged commit f34bc3c into neovim:master Sep 1, 2020
@justinmk
Copy link
Member

justinmk commented Sep 1, 2020

@rockerBOO how does one actually activate the dark mode?

@rockerBOO
Copy link
Contributor Author

Windows has an option to set your preference to dark.
Firefox has a about:config to set a preference (ui.systemUsesDarkTheme = 1).
GTK has gtk-application-prefer-dark-theme=1

@justinmk thank you! Thank you for your help!

@cweagans
Copy link
Contributor

cweagans commented Sep 1, 2020

Should we think about an alternate version of the logo that uses light text for dark mode? Grey on grey is a bit hard to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants