feat(search): match DocSearch style with Neovim #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Beautiful. Only nit is that the top-right search box is now rather subdued, I think it's useful for it to be somewhat attention-grabbing. Could its border be radioactive green like the popup input: 
|
|
I was going to do the same comment, the search bar is too subtle.The new modal is top notch |
|
Thanks for the feedback and glad you like it! Will make the changes by the end of the day |
|
It's better. Fine by me. You might want to rebase to resolve the merge conflict. |
shortcuts
force-pushed
the
feat/docsearch-style
branch
from
3afbee3 to
d4333dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at matching the DocSearch styles to the Neovim colors, see table for preview.
Feel free to suggest changes / color variations.