Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Merge Neovim.org & Dev Wiki #49

Merged
merged 24 commits into from
Jun 18, 2014
Merged

[RFC] Merge Neovim.org & Dev Wiki #49

merged 24 commits into from
Jun 18, 2014

Conversation

jdavis
Copy link
Contributor

@jdavis jdavis commented Jun 12, 2014

Here's what I have so far based on what was discussed in #47. I put the Donation section on the homepage, changed up the navigation, added the Polls section to the homepage, and moved the Style Guide to be located at /develop/style-guide.xml.

I've been trying to test out jekyll-redirect-from which is a plugin that we can use with GitHub Pages to do redirects but can't seem to get it to work locally. I'm going to continue to try to see if I can get it to work.

I don't know if there is any advantage to having the style-guide in XML. I think it might be better to have it as HTML and convert it to using the same colors as the website styling.

Anyways, I'll put the screenshots below (shrunken massively). Let me know what you think.

screen shot 2014-06-11 at 9 35 50 pm
screen shot 2014-06-11 at 9 35 59 pm

@justinmk
Copy link
Member

it seems odd that bower would be checked in, even if it was being used.

redirects for permanent links is a very good idea if it doesn't add too much complication.

I don't know if there is any advantage to having the style-guide in XML. I think it might be better to have it as HTML and convert it to using the same colors as the website styling.

Seems like a great idea to me. It's a one-time cost, and editing the XML isn't any nicer than editing some HTML. Would like to keep the show/hide behavior though.

I'll put the screenshots below (shrunken massively). Let me know what you think.

Why not put the poll in the negative space under the sponsers section? Might need to tighten up the verbiage though.

Great work, thanks for doing this!

@jdavis
Copy link
Contributor Author

jdavis commented Jun 17, 2014

Cool, I'll see if I can get the redirects working.

Also, I don't know why I didn't think of the Polls being under the Sponsors section. That is a good idea. I'll let you know when I've made the changes.

@jdavis
Copy link
Contributor Author

jdavis commented Jun 17, 2014

Okay, I have some redirects in place and moved the Polls section. I ended up putting it under the Stay Informed section; the different headers clashed being under the Sponsors section. Here's what it looks like:
screen shot 2014-06-17 at 5 50 12 pm

Here's what it looks like to make a redirect so it is really painless: c860f06

Let me know what you think, @justinmk.

@justinmk
Copy link
Member

Beautiful. 👍 Please merge it!

jdavis added a commit that referenced this pull request Jun 18, 2014
[RFC] Merge Neovim.org & Dev Wiki
@jdavis jdavis merged commit 4760611 into neovim:master Jun 18, 2014
@justinmk
Copy link
Member

http://neovim.org/ looks good :) Thanks again!

@jdavis jdavis deleted the merge-dev-wiki branch June 18, 2014 18:12
@Hinidu
Copy link

Hinidu commented Jun 23, 2014

@jdavis I just noticed that style guide page was moved. So we should reflect this in https://github.com/neovim/neovim/blob/master/CONTRIBUTING.md
Could you do that change? Or could I do it?
Generally: thank you for amazing work!

@jdavis
Copy link
Contributor Author

jdavis commented Jun 23, 2014

Hey @Hinidu, either of us could do it. I held off because @justinmk noted that he wants to update it neovim/neovim#740 (comment) here. I think it'd probably be beneficial to merge in those changes if they are finished. If not, then at least updating the link to the style-guide would be good. But I know Justin is pretty busy with other things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants