frontend: Uses feature keys to retrieve flag values

nephomaniac · Apr 27, 2018 · 76b5f7e · 76b5f7e
1 parent efb15f6
commit 76b5f7e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/frontend/public/components/cluster-overview-container.jsx b/frontend/public/components/cluster-overview-container.jsx
@@ -17,14 +17,14 @@ class ClusterOverviewContainer_ extends SafetyFirst {
 
   componentDidMount() {
     super.componentDidMount();
-    if (this.props.flags.SECURITY_LABELLER) {
+    if (this.props.flags[FLAGS.SECURITY_LABELLER]) {
       this._checkFixableIssues();
       this._checkScannedPods();
     }
   }
 
   componentWillReceiveProps (nextProps) {
-    if (this.props.flags.SECURITY_LABELLER || !nextProps.flags.SECURITY_LABELLER) {
+    if (this.props.flags[FLAGS.SECURITY_LABELLER] || !nextProps.flags[FLAGS.SECURITY_LABELLER]) {
       return;
     }
     if (_.isFinite(this.state.fixableIssues) || _.isFinite(this.state.scannedPods)) {

diff --git a/frontend/public/components/namespace.jsx b/frontend/public/components/namespace.jsx
@@ -200,16 +200,17 @@ const NamespaceDropdown = connect(() => ({activeNamespace: getActiveNamespace()}
 });
 
 const NamespaceSelector_ = props => {
-  if (props.flags.OPENSHIFT === undefined) {
+  const openshiftFlag = props.flags[FLAGS.OPENSHIFT];
+  if (openshiftFlag === undefined) {
     // Wait until the flag is initialized.
     return <div className="co-namespace-selector" />;
   }
 
-  const model = getModel(props.flags.OPENSHIFT);
+  const model = getModel(openshiftFlag);
   const resources = [{ kind: model.kind, prop: 'namespace', isList: true }];
 
   return <Firehose resources={resources}>
-    <NamespaceDropdown useProjects={props.flags.OPENSHIFT} />
+    <NamespaceDropdown useProjects={openshiftFlag} />
   </Firehose>;
 };