Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert interact #7

Merged
merged 6 commits into from
Sep 26, 2021
Merged

Revert interact #7

merged 6 commits into from
Sep 26, 2021

Conversation

jennan
Copy link
Collaborator

@jennan jennan commented Sep 26, 2021

It looks like the issue with getting ipywidgets to work in a conda environment comes from the version packaged in the default channel. Using conda-forge to create the conda environment fixes this problem. This PR reverts PR #3 changes.

This reverts commit 25bd687, reversing
changes made to b880202.

Conflicts:
	notebooks/03.2-Regression-Forests.ipynb
	notebooks/fig_code/figures.py
It looks like the current version of ipywidgets from the default conda channel is broken.
Using conda-forge fixes this.
@jennan
Copy link
Collaborator Author

jennan commented Sep 26, 2021

@pletzer please could you test this locally (you need to create a new conda environment) and on NeSI? Thank you :).

@pletzer
Copy link
Collaborator

pletzer commented Sep 26, 2021

Hi @jennan

I'm getting this warning in 02.2 on my laptop in the env I created using the README.md instructions:
Uploading Screen Shot 2021-09-27 at 7.42.00 AM.png…

@pletzer
Copy link
Collaborator

pletzer commented Sep 26, 2021

Also in 02.2 on my laptop:
Screen Shot 2021-09-27 at 7 45 50 AM

@pletzer
Copy link
Collaborator

pletzer commented Sep 26, 2021

The sliders work great in 03.2 but there a warning at the bottom:
Uploading Screen Shot 2021-09-27 at 7.52.47 AM.png…

@pletzer
Copy link
Collaborator

pletzer commented Sep 26, 2021

I think we need to add pandas (lesson 6):

Screen Shot 2021-09-27 at 7 57 00 AM

@jennan jennan merged commit 57a7dc6 into master Sep 26, 2021
@jennan jennan deleted the revert_interact branch September 26, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants