Some style fixes #27
Some style fixes #27
Conversation
| @@ -81,7 +81,7 @@ def function(): | |||
| def _convert_exceptions(func, *args, **kwargs): | |||
| try: | |||
| return func(*args, **kwargs) | |||
| except catch_types or () as e: | |||
| except(catch_types, ()) as e: | |||
There was a problem hiding this comment.
I think you still want a space after except. This isn't a function call. http://stackoverflow.com/a/6470452
There was a problem hiding this comment.
Well yes. Updating.
|
Line 258 of this file and line 55 of test_metis.py longer than 79 chars. Might want to fix that. |
|
@chebee7i You should turn on the option of "Build only if .travis.yml is present" option. |
|
You are a maintainer on it, so you should configure it however networkx-metis needs it to be configured. |
I don't have the option to configure it (Travis?). I guess only owners and collaborators can do it. |
|
Oh sorry you meant for travis....yeah, I was referring to readthedocs. |
|
I edited the long line of this file. The line in |
| @@ -81,7 +81,7 @@ def function(): | |||
| def _convert_exceptions(func, *args, **kwargs): | |||
| try: | |||
| return func(*args, **kwargs) | |||
| except catch_types or () as e: | |||
| except (catch_types, ()) as e: | |||
There was a problem hiding this comment.
Removing or () should be good enough. (catch_types, ()) is wrong.
|
Are we good here? |
Fix https://landscape.io/github/OrkoHunter/networkx-metis/3/messages/error
Exception to catch is the result of a binary “%s” operation Used when the exception to catch is of the form “except A or B:”. If intending to catch multiple, rewrite as “except (A, B):”
It seems that populating
networkx/addons/metis/__init__.pyhas generated a couple of cyclic imports.https://landscape.io/github/OrkoHunter/networkx-metis/3/messages/smell
They can be fixed by usingfrom . import modulewhich I think is okay to do.Nope. Can't fix that.