Skip to content

Commit

Permalink
drm/qxl: return IRQ_NONE if it was not our irq
Browse files Browse the repository at this point in the history
Return IRQ_NONE if it was not our irq. This is necessary for the case
when qxl is sharing irq line with a device A in a crash kernel. If qxl
is initialized before A and A's irq was raised during this gap,
returning IRQ_HANDLED in this case will cause this irq to be raised
again after EOI since kernel think it was handled but in fact it was
not.

Cc: Gerd Hoffmann <[email protected]>
Cc: [email protected]
Signed-off-by: Jason Wang <[email protected]>
Signed-off-by: Dave Airlie <[email protected]>
  • Loading branch information
jasowang authored and airlied committed Jul 16, 2014
1 parent 85d9e14 commit fbb60fe
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/gpu/drm/qxl/qxl_irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ irqreturn_t qxl_irq_handler(int irq, void *arg)

pending = xchg(&qdev->ram_header->int_pending, 0);

if (!pending)
return IRQ_NONE;

atomic_inc(&qdev->irq_received);

if (pending & QXL_INTERRUPT_DISPLAY) {
Expand Down

0 comments on commit fbb60fe

Please sign in to comment.