-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5단계 - 자동차 경주(리팩터링) #918
Open
relkimm
wants to merge
17
commits into
next-step:relkimm
Choose a base branch
from
relkimm:step5
base: relkimm
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
5단계 - 자동차 경주(리팩터링) #918
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
41be7a3
refactor: 패키지를 domain & view 로 분리
relkimm 32edb84
refactor: CarName 글자수 검사 시 require 사용하도록 변경
relkimm 3392656
feat: 기존 자동차를 통해 새로운 자동차 생성하는 로직 추가
relkimm ffe32fd
refactor: 자동차가 주행하고 나서 새로운 자동차를 반환하도록 수정
relkimm ccb8ca3
refactor: CarGroup 에서 자동차가 주행하더라도 불변하도록 수정
relkimm 28acace
refactor: Store pub/sub 구조로 변경
relkimm ee967ec
feat: 라운드 관련 UI 를 표시하는 RoundComponent 추가
relkimm 51ab1c0
refactor: Winner 를 표시하는 UI container/presentational 컴포넌트로 분리
relkimm b31626d
refactor: Round 를 표시하는 UI container/presentational 컴포넌트로 분리
relkimm e8b33e2
feat: 자동차 위치를 표시하는 UI container/presentational 컴포넌트 추가
relkimm 81e58af
refactor: 불필요한 RoundResult 정리
relkimm 459562a
refactor: RoundList 와 Round 를 표시하는 UI 분리
relkimm b4497de
refactor: DistanceComponent 네이밍 변경
relkimm a0bb3ab
refactor: 프로퍼티에는 this 붙이도록 수정
relkimm 6aed63f
refactor: RoundContainer 에서 라운드 시작하는 로직 render 와 분리
relkimm 3e6350e
feat: 자동차 이름 공백인 경우 유효성 검사 추가
relkimm 133c53c
refactor: store 공통으로 사용할 수 있도록 개선
relkimm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: 자동차 이름 공백인 경우 유효성 검사 추가
- Loading branch information
commit 3e6350e2b54cfeb37aa571e1851a0cb99e59db11
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
마이너하지만
.not()
을 사용하게 되면서 가독성이 약간은 떨어지게 된 거 같아요~아래와 같이 좀 더 간결하게 작성하는 것도 좋을 거 같습니다!