Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dynamite_end_to_end_test): Add string enum with a keyword value #1243

Merged
merged 1 commit into from
Dec 12, 2023
Merged

feat(dynamite_end_to_end_test): Add string enum with a keyword value #1243

merged 1 commit into from
Dec 12, 2023

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Dec 7, 2023 •
edited
Loading

@provokateurin provokateurin marked this pull request as draft December 7, 2023 07:33
@provokateurin provokateurin force-pushed the feat/dynamite_end_to_end_test/string-enum-keyword-value branch from 21b911d to d66f957 Compare December 7, 2023 07:40
Leptopoda
Leptopoda requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enums can get fairly complex (all the different subschemas).
Should we add these schemas to a separate spec (thinking of "enum.openapi.dart").

Please also unit test the generated code.

@provokateurin provokateurin force-pushed the feat/dynamite_end_to_end_test/string-enum-keyword-value branch from d66f957 to b1fba41 Compare December 12, 2023 15:00
@provokateurin provokateurin marked this pull request as ready for review December 12, 2023 15:01
@provokateurin provokateurin force-pushed the feat/dynamite_end_to_end_test/string-enum-keyword-value branch from b1fba41 to 8eb397f Compare December 12, 2023 15:03
@provokateurin provokateurin force-pushed the feat/dynamite_end_to_end_test/string-enum-keyword-value branch from 8eb397f to 31653ae Compare December 12, 2023 15:22
@provokateurin provokateurin mentioned this pull request Dec 12, 2023
Closed
@provokateurin provokateurin merged commit 5204716 into main Dec 12, 2023
8 checks passed
@provokateurin provokateurin deleted the feat/dynamite_end_to_end_test/string-enum-keyword-value branch December 12, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leptopoda Leptopoda Leptopoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

String enums with default as one of the possible values are broken
2 participants
@provokateurin @Leptopoda