feat(nextcloud_test): Add fixture recording and validation #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
force-pushed
the
feat/nextcloud_test/fixtures
branch
from
cc0aced to
864e969
Compare
Leptopoda
reviewed
Dec 12, 2023
packages/dynamite/dynamite_runtime/lib/src/http_extensions.dart
Outdated
Show resolved
Hide resolved
Signed-off-by: jld3103 <[email protected]>
Signed-off-by: jld3103 <[email protected]>
provokateurin
force-pushed
the
feat/nextcloud_test/fixtures
branch
from
864e969 to
c442291
Compare
|
Sure. Do you want me to create a dynamite_test package out of this so we can also utilize it for petstore and the e2e tests? |
|
I think that these packages can utilise nextxloud_test directly. I don't see the benefit of a separate package. |
|
The nextcloud_test package has a lot of nextcloud specific stuff so it's not very clean to add it to the dynamite packages which are not nextcloud specific. |
|
But it's only for testing 🤷♀️ |
|
Let's keep it as is for now but once we want this in other packages as well we should move it to a separate package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This system records HTTP requests and compares them to some saved pattern. This ensures we never have any changes in the raw requests that we don't know about.
Ideally we create a dynamite_test package so that we can reuse this system for dynamite_petstore_example and dynamite_end_to_end_test. I can do that in this PR already if it is favorable.
There is no performance impact to the tests:
#435