-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Trimmomatic, support contig for bining, set concoct default parameters #745
Added Trimmomatic, support contig for bining, set concoct default parameters #745
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to make the use of scaffolds/contigs for binning a param rather than a replacement
57f463f
to
b1eb9ed
Compare
I have added a new parameter |
closes #744 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now....lets get a review from #mag ppl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please add running trimmomatic to one of the test configs so we know it can execute at least once
And generally missing docs!
- Listing in the README
- Missing output.md
Otherwise code looks good! Just some consistency things
@Pranjal-Bioinfo I'm assuming you're still busy, so I'll take this over for the last bit, and include it in the next release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a few changes but otherwise LGTM!
@sateeshperi want to be included in the CHANGELOG as it looks like you somewhat supervised?
Included Trimmomatic
Added clip tool as trimmmomatic. removed skip_concoct=true
added ext.args ='c 10000 -o 0 --merge_last at 642
614bed1
to
f9787f9
Compare
Hi @sateeshperi This is ready now. Kindly have a look when you have some time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi all, looks good to me! A couple of very minor comments + 1 query about template changes
Co-authored-by: Jim Downie <[email protected]>
Need to update |
What do you mean exactly @sateeshperi ? Generally I don't describe parameters much in Eventually I would like ot write proper tutorials where I think such information would be more useful. |
makes sense |
Woohoo! Thank you very much @Pranjal-Bioinfo @GallVp @sateeshperi @prototaxites ! Team effor ton this one :D |
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).