Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Trimmomatic, support contig for bining, set concoct default parameters #745

Merged
merged 33 commits into from
Apr 1, 2025

Conversation

Pranjal-Bioinfo
Copy link

@Pranjal-Bioinfo Pranjal-Bioinfo commented Jan 17, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

This comment was marked as outdated.

@Pranjal-Bioinfo Pranjal-Bioinfo changed the base branch from master to dev January 17, 2025 09:03
Copy link
Contributor

@sateeshperi sateeshperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to make the use of scaffolds/contigs for binning a param rather than a replacement

@GallVp GallVp force-pushed the Trimmomatic-contig-concoct branch from 57f463f to b1eb9ed Compare January 20, 2025 07:30
@GallVp
Copy link
Member

GallVp commented Jan 20, 2025

need to make the use of scaffolds/contigs for binning a param rather than a replacement

I have added a new parameter spades_use_contigs_not_scaffolds, rebased the branch on top of the current dev and restored logos to pass the lint checks. I can see that CHANGELOG.md has not been updated and there isn't any issue linked to this PR. Anyone of us taking care of that?

@sateeshperi
Copy link
Contributor

closes #744

Copy link
Contributor

@sateeshperi sateeshperi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now....lets get a review from #mag ppl

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please add running trimmomatic to one of the test configs so we know it can execute at least once

And generally missing docs!

  • Listing in the README
  • Missing output.md

Otherwise code looks good! Just some consistency things

@jfy133
Copy link
Member

jfy133 commented Mar 31, 2025

@Pranjal-Bioinfo I'm assuming you're still busy, so I'll take this over for the last bit, and include it in the next release

Copy link
Member

@jfy133 jfy133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few changes but otherwise LGTM!

@sateeshperi want to be included in the CHANGELOG as it looks like you somewhat supervised?

@jfy133 jfy133 requested a review from sateeshperi March 31, 2025 08:57
@sateeshperi sateeshperi assigned GallVp and unassigned Pranjal-Bioinfo Apr 1, 2025
@GallVp GallVp force-pushed the Trimmomatic-contig-concoct branch from 614bed1 to f9787f9 Compare April 1, 2025 07:28
@GallVp
Copy link
Member

GallVp commented Apr 1, 2025

Hi @sateeshperi

This is ready now. Kindly have a look when you have some time.

Copy link
Contributor

@prototaxites prototaxites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi all, looks good to me! A couple of very minor comments + 1 query about template changes

@sateeshperi
Copy link
Contributor

Need to update docs/usage.md to indicate how to use configs/scaffolds and chunk size and overlap params.

@jfy133
Copy link
Member

jfy133 commented Apr 1, 2025

What do you mean exactly @sateeshperi ?

Generally I don't describe parameters much in usage.md, there are so many parameters in mag it would basically duplicate the parameters tab :smile_sweat:, unless you had a specific idea?

Eventually I would like ot write proper tutorials where I think such information would be more useful.

@sateeshperi
Copy link
Contributor

makes sense

@jfy133
Copy link
Member

jfy133 commented Apr 1, 2025

Woohoo! Thank you very much @Pranjal-Bioinfo @GallVp @sateeshperi @prototaxites ! Team effor ton this one :D

@jfy133 jfy133 merged commit f49ce2f into nf-core:dev Apr 1, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants