Add sam2lca/updadb module #7059
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sateeshperi
reviewed
Dec 1, 2024
| then { | ||
| assertAll( | ||
| { assert process.success } | ||
| ) |
There was a problem hiding this comment.
how is the snapshot created if there is no assertion for it here ?
There was a problem hiding this comment.
I removed the snapshot, and added other assertions
There was a problem hiding this comment.
I think we should at least snapshot the versions and add a snap here :)
famosab
reviewed
Dec 11, 2024
|
I believe your suggestions have been adressed @famosab @sateeshperi :) |
famosab
reviewed
Dec 18, 2024
| then { | ||
| assertAll( | ||
| { assert process.success } | ||
| ) |
There was a problem hiding this comment.
I think we should at least snapshot the versions and add a snap here :)
| """ | ||
|
|
||
| stub: | ||
| prefix = 'sam2lca_db' |
There was a problem hiding this comment.
Suggested change
| prefix = 'sam2lca_db' | |
| prefix = task.ext.prefix ?: 'sam2lca_db' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And update sam2lca versions to 1.1.4
PR checklist
versions.ymlfile.labelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda