Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main.nf #7120

Merged
merged 4 commits into from
Dec 18, 2024
Merged

Update main.nf #7120

merged 4 commits into from
Dec 18, 2024

Conversation

amizeranschi
Copy link
Contributor

@amizeranschi amizeranschi requested a review from jasmezz November 29, 2024 07:54
Copy link
Member

@mahesh-panchal mahesh-panchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This particular change is fine, but please get the tests to work by updating the test snapshots.

nf-core modules test rgi/main --profile <docker/singularity/conda> --update

@jasmezz
Copy link
Contributor

jasmezz commented Dec 10, 2024

I updated the snapshot and tests are succeeding locally. ✔️

Why they don't here on GHA: because the untar module (as part of the main.nf.test file) uses ubuntu version 22.04. A previous module version used 20.04 with which all tests succeeded back then and still do now if I change the version back to 20.04 locally. This problem was reported and discussed already in June (see Slack convo here), but not fixed yet, apparently.
Would you @mahesh-panchal be fine with merging this PR incl. failing tests when I assure that tests are fine locally? I attached screenshots in the Slack convo. This PR does not interfere with any of this anyway, it just wants to fix a typo in a variable 😬

mahesh-panchal
mahesh-panchal previously approved these changes Dec 10, 2024
Copy link
Member

@mahesh-panchal mahesh-panchal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linking related #5971 and #5968.
@maxulysse What's the plan on implementing this unified container?

@maxulysse
Copy link
Member

is quay.io/nf-core/coreutils_grep_gzip_lbzip2_pruned:10736d98b4d693d8 working as expecting (ie containing the missing lib)?

@jasmezz jasmezz added this pull request to the merge queue Dec 18, 2024
Merged via the queue into master with commit 41623bc Dec 18, 2024
27 checks passed
@jasmezz jasmezz deleted the amizeranschi-patch-1 branch December 18, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The parameter arg_rgi_alignmenttool doesn't have any effect
4 participants