Skip to content

Commit

Permalink
Filter out CSS files from middleware files and client reference chunks (
Browse files Browse the repository at this point in the history
vercel#57482)

There could be CSS files emitted in these chunks so both manifests need
to filter them out. This fixes `app dir - css css support chunks should
bundle css resources into chunks`.
  • Loading branch information
shuding authored Oct 26, 2023
1 parent abb34da commit 618d674
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/next-swc/crates/next-api/src/app.rs
Original file line number Diff line number Diff line change
Expand Up @@ -865,6 +865,7 @@ impl AppEndpoint {
async move {
Ok(node_root_value
.get_path_to(&*file.ident().path().await?)
.filter(|path| path.ends_with(".js"))
.map(|path| path.to_string()))
}
}
Expand All @@ -882,6 +883,7 @@ impl AppEndpoint {
async move {
Ok(node_root_value
.get_path_to(&*file.ident().path().await?)
.filter(|path| path.ends_with(".js"))
.map(|path| path.to_string()))
}
})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,9 @@ impl ClientReferenceManifest {
.iter()
.filter_map(|chunk_path| client_relative_path.get_path_to(chunk_path))
.map(ToString::to_string)
// It's possible that a chunk also emits CSS files, that will
// be handled separatedly.
.filter(|path| path.ends_with(".js"))
.collect::<Vec<_>>();

let ssr_chunks_paths = ssr_chunks
Expand Down

0 comments on commit 618d674

Please sign in to comment.