add validation for volname

ng29 · Oct 31, 2017 · cd2ba3f · cd2ba3f
1 parent 1c46198
commit cd2ba3f
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/cmd/mayactl/app/command/volume_create.go b/cmd/mayactl/app/command/volume_create.go
@@ -52,7 +52,8 @@ func NewCmdVolumeCreate() *cobra.Command {
 		Short: "Creates a new Volume",
 		Long:  volumeCreateCommandHelpText,
 		Run: func(cmd *cobra.Command, args []string) {
-			util.CheckErr(RunVolumeCreate(cmd, &options), util.Fatal)
+			util.CheckErr(options.Validate(cmd), util.Fatal)
+			util.CheckErr(options.RunVolumeCreate(cmd), util.Fatal)
 		},
 	}
 
@@ -67,7 +68,15 @@ func NewCmdVolumeCreate() *cobra.Command {
 }
 
 // Run does tasks related to mayaserver.
-func RunVolumeCreate(cmd *cobra.Command, c *CmdVolumeCreateOptions) error {
+func (c *CmdVolumeCreateOptions) Validate(cmd *cobra.Command) error {
+	if c.volName == "" {
+		return errors.New("--volname is missing. Please specify an unique name")
+	}
+	return nil
+}
+
+// Run does tasks related to mayaserver.
+func (c *CmdVolumeCreateOptions) RunVolumeCreate(cmd *cobra.Command) error {
 	fmt.Println("Executing volume create...")
 
 	resp := mapiserver.CreateVolume(c.volName, c.size)