Skip to content

Commit

Permalink
Address PR comments from Nick
Browse files Browse the repository at this point in the history
  • Loading branch information
tiembo authored and florina-muntenescu committed Oct 21, 2018
1 parent 967dfab commit 7262f09
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 18 deletions.
14 changes: 7 additions & 7 deletions app/src/main/res/layout/activity_home.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@
-->

<androidx.drawerlayout.widget.DrawerLayout xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/drawer"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:clipToPadding="false"
tools:context=".ui.HomeActivity">
xmlns:app="http://schemas.android.com/apk/res-auto"
xmlns:tools="http://schemas.android.com/tools"
android:id="@+id/drawer"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:clipToPadding="false"
tools:context=".ui.HomeActivity">

<FrameLayout
android:layout_width="match_parent"
Expand Down
1 change: 0 additions & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ buildscript {
'retrofit' : '2.4.0',
'retrofitCoroutines': '0.9.2',
'room' : '2.1.0-alpha01',
'supportLibrary' : '27.1.1',
'test_rules' : '1.1.0-beta02',
'test_runner' : '1.1.0-beta02',
'ui_automator' : '2.2.0-beta02'
Expand Down
2 changes: 1 addition & 1 deletion core/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -72,13 +72,13 @@ dependencies {
api "androidx.core:core-ktx:${versions.coreKtx}"
api "androidx.constraintlayout:constraintlayout:${versions.constraintLayout}"
api "androidx.browser:browser:${versions.legacy_support}"
api "com.google.android.material:material:${versions.legacy_support}"
api "androidx.palette:palette:${versions.legacy_support}"
api "androidx.recyclerview:recyclerview:${versions.legacy_support}"
api "androidx.dynamicanimation:dynamicanimation:${versions.legacy_support}"
api "com.github.bumptech.glide:glide:${versions.glide}"
api "com.github.bumptech.glide:okhttp3-integration:${versions.glide}"
api "com.github.bumptech.glide:recyclerview-integration:${versions.glide}"
api "com.google.android.material:material:${versions.legacy_support}"
api "com.google.code.gson:gson:${versions.gson}"
api "com.google.dagger:dagger:${versions.dagger}"
api "com.squareup.retrofit2:retrofit:${versions.retrofit}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,8 @@

package io.plaidapp.core.ui.recyclerview;

import androidx.recyclerview.widget.RecyclerView;

/**
* A marker interface used by {@link RecyclerView.ItemDecoration}s to
* denote {@link RecyclerView.ViewHolder}s that should have dividers.
* A marker interface used by {RecyclerView.ItemDecoration}s to
* denote {RecyclerView.ViewHolder}s that should have dividers.
*/
public interface Divided { }
5 changes: 1 addition & 4 deletions designernews/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,6 @@ android {
enabled true
}

dependencies {
implementation("androidx.arch.core:core-runtime:2.0.1-alpha01")
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
Expand All @@ -54,6 +50,7 @@ repositories {

dependencies {
implementation project(':app')
implementation("androidx.arch.core:core-runtime:2.0.1-alpha01")

testImplementation project(':test_shared')

Expand Down
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.1-bin.zip

0 comments on commit 7262f09

Please sign in to comment.