Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support allowedURLs #496

Merged
merged 8 commits into from
Nov 11, 2024
Merged

Support allowedURLs #496

merged 8 commits into from
Nov 11, 2024

Conversation

hjkatz
Copy link
Contributor

@hjkatz hjkatz commented Nov 8, 2024

What

Describe what the change is solving

Add regex validation to allowedURLs

Add conversion functions and tests

Create method to allow/deny BoundEndpoint projection

Deny BoundEndpoints based on allowedURLs

How

Describe the solution

Breaking Changes

Are there any breaking changes in this PR?
No.

@hjkatz hjkatz requested a review from a team as a code owner November 8, 2024 19:23
@github-actions github-actions bot added area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart labels Nov 8, 2024
@hjkatz Graphite App
Copy link
Contributor Author

hjkatz commented Nov 8, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hjkatz and the rest of your teammates on Graphite Graphite

@hjkatz hjkatz force-pushed the hkatz/allowed-urls branch from dc7a0f0 to 4987c73 Compare November 8, 2024 20:08
@hjkatz Graphite App
Copy link
Contributor Author

hjkatz commented Nov 8, 2024 •
edited
Loading

Merge activity

  • Nov 8, 4:09 PM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Nov 11, 11:48 AM EST: A user merged this pull request with Graphite.

@hjkatz hjkatz force-pushed the hkatz/allowed-urls branch from d9f2863 to b3144a6 Compare November 8, 2024 21:18
@github-actions github-actions bot added the meta/project Issues/PRs related to maintaining the project label Nov 11, 2024
@hjkatz hjkatz force-pushed the hkatz/allowed-urls branch from 65f27a0 to db21607 Compare November 11, 2024 16:41
@github-actions github-actions bot removed the meta/project Issues/PRs related to maintaining the project label Nov 11, 2024
@hjkatz hjkatz merged commit e4eb3ed into main Nov 11, 2024
9 checks passed
@hjkatz hjkatz deleted the hkatz/allowed-urls branch November 11, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonstacks jonstacks jonstacks approved these changes

Assignees
No one assigned
Labels
area/controller Issues dealing with the controller area/helm-chart Issues dealing with the helm chart
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjkatz @jonstacks