Skip to content

Commit

Permalink
Include all files in the bundle, not just PNGs, in Cocoapods resource…
Browse files Browse the repository at this point in the history
… bundle

This change has no functional effect at this time. However, now that we have a proper bundle in the repo, it seems proper to direct CocoaPods to package _all_ files in that bundle into its (equivalent) resource bundle.

This eliminates room for future error: if a non-PNG file is added to the bundle, before this change, it would appear to work with Carthage but not with CocoaPods.
  • Loading branch information
cdzombak committed Mar 8, 2016
1 parent 2752f7d commit e3e7353
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion NYTPhotoViewer.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Pod::Spec.new do |s|
s.requires_arc = true

s.subspec 'Core' do |ss|
ss.ios.resource_bundle = { s.name => ['NYTPhotoViewer/NYTPhotoViewer.bundle/*.png'] }
ss.ios.resource_bundle = { s.name => ['NYTPhotoViewer/NYTPhotoViewer.bundle/*'] }
ss.source_files = 'NYTPhotoViewer/**/*.{h,m,swift}'
ss.frameworks = 'UIKit', 'Foundation'
end
Expand Down

0 comments on commit e3e7353

Please sign in to comment.