Skip to content

Commit

Permalink
containers: Fix duplicate group name for gid=0
Browse files Browse the repository at this point in the history
The definitions of group entries for gid=0 used the same
names as previously defined groups, which gives misleading
`ls -l` output in the container

bash-5.0$ stat /usr/bin/alias | grep Gid
Access: (0755/-rwxr-xr-x)  Uid: (    0/    root)   Gid: (    0/    qemu)
bash-5.0$ ls -l /usr/bin/alias
-rwxr-xr-x. 1 root qemu 33 Jan  1  1970 /usr/bin/alias
bash-5.0$ id
uid=107(qemu) gid=107(qemu) groups=107(qemu)

This seems like a copy+paste accident.
Rename the groups to 'root'

Signed-off-by: Cole Robinson <[email protected]>
  • Loading branch information
crobinso committed Mar 15, 2021
1 parent fab812c commit cc5041f
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cmd/virt-handler/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ group_entry(
group_entry(
name = "root-group",
gid = 0,
groupname = "qemu",
groupname = "root",
)

group_file(
Expand Down
2 changes: 1 addition & 1 deletion cmd/virt-launcher/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ group_entry(
group_entry(
name = "root-group",
gid = 0,
groupname = "qemu",
groupname = "root",
)

group_file(
Expand Down
2 changes: 1 addition & 1 deletion images/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ group_entry(
group_entry(
name = "root-group",
gid = 0,
groupname = "nginx",
groupname = "root",
)

group_file(
Expand Down

0 comments on commit cc5041f

Please sign in to comment.