add CHEF::Rest#get func tests

nhuff · Apr 22, 2014 · 662507a · 662507a
1 parent 23c5d8d
commit 662507a
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/spec/functional/http/simple_spec.rb b/spec/functional/http/simple_spec.rb
@@ -64,6 +64,7 @@
     end
   end
 
+  # see CHEF-5100
   shared_examples_for "a 403 after a successful request when reusing the request object" do
     it "fails with a Net::HTTPServerException for a streaming request" do
       tempfile = http_client.streaming_request(source)

diff --git a/spec/functional/rest_spec.rb b/spec/functional/rest_spec.rb
@@ -32,27 +32,49 @@
       tempfile.close
       expect(Digest::MD5.hexdigest(binread(tempfile.path))).to eq(Digest::MD5.hexdigest(expected_content))
     end
+
+    it "successfully downloads a GET request" do
+      tempfile = http_client.get(source, {})
+      tempfile.close
+      expect(Digest::MD5.hexdigest(binread(tempfile.path))).to eq(Digest::MD5.hexdigest(expected_content))
+    end
   end
 
   shared_examples_for "validates content length and throws an exception" do
     it "fails validation on a streaming download" do
       expect { http_client.streaming_request(source, {}) }.to raise_error(Chef::Exceptions::ContentLengthMismatch)
     end
+
+    it "fails validation on a GET request" do
+      expect { http_client.get(source, {}) }.to raise_error(Chef::Exceptions::ContentLengthMismatch)
+    end
   end
 
   shared_examples_for "an endpoint that 403s" do
-    it "fails with a Net::HTTPServerException" do
+    it "fails with a Net::HTTPServerException on a streaming download" do
       expect { http_client.streaming_request(source, {}) }.to raise_error(Net::HTTPServerException)
     end
+
+    it "fails with a Net::HTTPServerException on a GET request" do
+      expect { http_client.get(source, {}) }.to raise_error(Net::HTTPServerException)
+    end
   end
 
+  # see CHEF-5100
   shared_examples_for "a 403 after a successful request when reusing the request object" do
-    it "fails with a Net::HTTPServerException" do
+    it "fails with a Net::HTTPServerException on a streaming download" do
       tempfile = http_client.streaming_request(source, {})
       tempfile.close
       expect(Digest::MD5.hexdigest(binread(tempfile.path))).to eq(Digest::MD5.hexdigest(expected_content))
       expect { http_client.streaming_request(source2, {}) }.to raise_error(Net::HTTPServerException)
     end
+
+    it "fails with a Net::HTTPServerException on a GET request" do
+      tempfile = http_client.get(source, {})
+      tempfile.close
+      expect(Digest::MD5.hexdigest(binread(tempfile.path))).to eq(Digest::MD5.hexdigest(expected_content))
+      expect { http_client.get(source2, {}) }.to raise_error(Net::HTTPServerException)
+    end
   end
 
   before do