Skip to content

Commit

Permalink
gdb: compile with -fcommon explicitly
Browse files Browse the repository at this point in the history
As described in the comment, gdb relies on some of the linker magic that
happens with -fcommon. I suspect the life expectancy of gdb-in-base is low
enough that this isn't worth spending much time addressing, especially given
the vintage. Hit it with the -fcommon hammer so that it continues to just
work.

MFC after:	3 days
  • Loading branch information
kevans91 committed Mar 29, 2020
1 parent 006eb44 commit 6f00f42
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions gnu/usr.bin/gdb/Makefile.inc
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,11 @@ CFLAGS+= -I${CNTRB_GDB}/include
CFLAGS+= -I${CNTRB_BU}/bfd
CFLAGS+= -I${SYSROOT:U${DESTDIR}}/${INCLUDEDIR}/edit

# Some bits here currently rely on some of the linker-merging magic that happens
# with -fcommon. While this is the default right now, explicitly set -fcommon
# so that it continues to build when the default flips.
CFLAGS+= -fcommon

GENSRCS+= nm.h tm.h

.if defined(GDB_CROSS_DEBUGGER)
Expand Down

0 comments on commit 6f00f42

Please sign in to comment.