Skip to content

Commit

Permalink
[x] don't ignore deleted files in changed-since
Browse files Browse the repository at this point in the history
Realized that you can do something silly like just delete a file without
affecting any others.

Tested by deleting storage/libradb/src/metrics.rs, then running `cargo xbuild
--changed-since HEAD` and seeing that libradb and a bunch of other packages
were re-tested.

Closes: aptos-labs#6747
  • Loading branch information
sunshowers authored and bors-libra committed Nov 23, 2020
1 parent e2e82af commit bc134f4
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions devtools/x/src/changed_since.rs
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,9 @@ pub(crate) fn changed_since_impl<'g>(xctx: &'g XContext, base: &str) -> Result<P
},
|| {
// Get the list of files changed between the merge base and the current dir.
// diff_filter = "d" means "skip over deleted files".
trace!("getting files changed");
git_cli
.files_changed_between(&merge_base, None, Some("d"))
.files_changed_between(&merge_base, None, None)
.with_context(|| "error while getting files changed from merge base")
},
)
Expand Down

0 comments on commit bc134f4

Please sign in to comment.