ofproto-dpif-xlate: Fix VLOG_ERR_RL() call.

a716ef9 ("ofproto-dpif-xlate: Log flow in XLATE_REPORT_ERROR.") inadvertantly broke build on clang due to improper passing of the ds cstring into the VLOG() function: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security] XLATE_REPORT_ERROR(ctx, "over max translation depth %d", MAX_DEPTH); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ note: expanded from macro 'XLATE_REPORT_ERROR' VLOG_ERR_RL(&error_report_rl, ds_cstr(&ds)); \ Reported-by: Daniele Di Proietto <[email protected]> Signed-off-by: Joe Stringer <[email protected]> Acked-by: Daniele Di Proietto <[email protected]>
nicboul · Aug 12, 2016 · 26f858a · 26f858a
1 parent a716ef9
commit 26f858a
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/ofproto/ofproto-dpif-xlate.c b/ofproto/ofproto-dpif-xlate.c
@@ -637,7 +637,7 @@ static struct vlog_rate_limit error_report_rl = VLOG_RATE_LIMIT_INIT(1, 5);
             ds_put_format(&ds, __VA_ARGS__);                    \
             ds_put_cstr(&ds, ": ");                             \
             flow_format(&ds, &ctx->base_flow);                  \
-            VLOG_ERR_RL(&error_report_rl, ds_cstr(&ds));        \
+            VLOG_ERR_RL(&error_report_rl, "%s", ds_cstr(&ds));  \
             ds_destroy(&ds);                                    \
         }                                                       \
     } while (0)