Skip to content

Commit

Permalink
ovsdb-tool.at: Drop monitor argument
Browse files Browse the repository at this point in the history
This patch drops the '--monitor' argument when running the ovsdb-server.

This can potentially increase the bug detection since the process will not
be restarted in certain situations.

Also, fixes the test under Windows since daemons do not have '--monitor'
argument.

Signed-off-by: Alin Gabriel Serdean <[email protected]>
Acked-by: Ben Pfaff <[email protected]>
Suggested-by: Ben Pfaff <[email protected]>
Suggested-at: https://mail.openvswitch.org/pipermail/ovs-dev/2018-April/346135.html
  • Loading branch information
aserdean committed Apr 16, 2018
1 parent 689829d commit 3915a9d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/ovsdb-tool.at
Original file line number Diff line number Diff line change
Expand Up @@ -443,15 +443,15 @@ AT_CHECK(
]], [ignore])

# Dump the data.
AT_CHECK([ovsdb-server -vfile -vvlog:off --monitor --detach --no-chdir --pidfile --log-file --remote=punix:db.sock db1])
AT_CHECK([ovsdb-server -vfile -vvlog:off --detach --no-chdir --pidfile --log-file --remote=punix:db.sock db1])
AT_CHECK([ovsdb-client dump > expout])
OVS_APP_EXIT_AND_WAIT([ovsdb-server])

# Create a clustered database from the standalone one.
ovsdb-tool create-cluster db2 db1 unix:s1.raft

# Dump the data.
AT_CHECK([ovsdb-server -vconsole:off -vfile -vvlog:off --monitor --detach --no-chdir --pidfile --log-file --remote=punix:db.sock db2])
AT_CHECK([ovsdb-server -vconsole:off -vfile -vvlog:off --detach --no-chdir --pidfile --log-file --remote=punix:db.sock db2])
AT_CHECK([ovsdb-client wait ordinals connected])
AT_CHECK([ovsdb-client dump > dump2])
OVS_APP_EXIT_AND_WAIT([ovsdb-server])
Expand Down

0 comments on commit 3915a9d

Please sign in to comment.