vlog: exit with error if explicitly specified logfile cannot be opened

It seems like if the user wanted a specific logfile but that request cannot be fulfilled, OVS/OVN shouldn't just continue as if nothing really happened (besides logging a warning). Signed-off-by: Dan Williams <[email protected]> Signed-off-by: Ben Pfaff <[email protected]>
nicboul · May 25, 2018 · dd8ff6c · dd8ff6c
1 parent 34d598d
commit dd8ff6c
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/include/openvswitch/vlog.h b/include/openvswitch/vlog.h
@@ -251,9 +251,15 @@ void vlog_rate_limit(const struct vlog_module *, enum vlog_level,
         case 'v':                               \
             vlog_set_verbosity(optarg);         \
             break;                              \
-        case OPT_LOG_FILE:                      \
-            vlog_set_log_file(optarg);          \
+        case OPT_LOG_FILE: {                    \
+            int err = vlog_set_log_file(optarg);\
+            /* Exit if logfile explicitly given \
+             * but cannot be opened. */         \
+            if (err && optarg) {                \
+                exit(EXIT_FAILURE);             \
+            }                                   \
             break;                              \
+        }                                       \
         case OPT_SYSLOG_IMPL:                   \
             vlog_set_syslog_method(optarg);     \
             break;                              \