Skip to content

Commit

Permalink
Fixed script output issue
Browse files Browse the repository at this point in the history
  • Loading branch information
Nick committed Jul 21, 2020
1 parent b66a155 commit 423dd41
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 27 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public void Should_Add_Mandatory_Arguments()
var result = fixture.Run();

// Then
Assert.Equal("ef migrations script list --no-build --json", result.Args);
Assert.Equal("ef migrations list --no-build --json", result.Args);
}

[Fact]
Expand All @@ -78,7 +78,7 @@ public void Should_Add_Path_Arguments()
var result = fixture.Run();

// Then
Assert.Equal("ef migrations script list --no-build --json --args=\"value\"", result.Args);
Assert.Equal("ef migrations list --no-build --json --args=\"value\"", result.Args);
Assert.Equal("/Working/tools/tool", result.Process.WorkingDirectory.FullPath);
}

Expand All @@ -89,17 +89,14 @@ public void Should_Add_Additional_Settings()
var fixture = new DotNetCoreEfMigrationScriptListerFixture();
fixture.Settings.StartupProject = "./src/MyMvcProject";
fixture.Settings.Project = "./src/MyDataProject";
fixture.Settings.From = "201702062047_Migration";
fixture.Settings.To = "201702062048_Migration";
fixture.Settings.Configuration = "release";
fixture.Settings.PrefixOutput = true;
fixture.Settings.MsBuildProjectExtensionsPath = "test-obj";
fixture.Settings.NoBuild = true;
// When
var result = fixture.Run();

// Then
Assert.Equal("ef migrations script list \"201702062047_Migration\" \"201702062048_Migration\" --project \"./src/MyDataProject\" --startup-project \"./src/MyMvcProject\" --prefix-output --no-build --json", result.Args);
Assert.Equal("ef migrations list --project \"./src/MyDataProject\" --startup-project \"./src/MyMvcProject\" --prefix-output --no-build --json", result.Args);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -58,21 +58,10 @@ private ProcessArgumentBuilder GetArguments(string project, ProcessArgumentBuild

builder.Append("ef");
builder.Append("migrations");
builder.Append("script");
builder.Append("list");

settings.SetProject(project);

if (!string.IsNullOrWhiteSpace(settings.From))
{
builder.AppendQuoted(settings.From);
}

if (!string.IsNullOrWhiteSpace(settings.To))
{
builder.AppendQuoted(settings.To);
}

if (!string.IsNullOrWhiteSpace(settings.Project))
{
builder.Append("--project");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,6 @@ namespace Cake.DotNetCoreEf.Migration
/// </summary>
public class DotNetCoreEfMigrationScriptListerSettings : DotNetCoreEfSettings
{
/// <summary>
/// The starting migration. If omitted, '0' (the initial database) is used.
/// </summary>
public string From { get; set; }

/// <summary>
/// The ending migration. If omitted, the last migration is used.
/// </summary>
public string To { get; set; }

/// <summary>
/// Prefix characters in output.
/// </summary>
Expand Down

0 comments on commit 423dd41

Please sign in to comment.