Skip to content

Commit

Permalink
Stores alphabetical sorting
Browse files Browse the repository at this point in the history
The bulk of this small change was to sort stores by alphabetical order according to translated names, instead of english strings.
This meant removing the ID splitting as well as hyphen/space replacing, as the ID is not considered for the test.
Also changed:
1. line 800: as the original english string is no longer necessary in the iteration, k takes the value of translated string. k is then used for alphabetical comparison (as before) with the right value.
2. line 816: removed the test on curPrev variable. Items already listed have been placed in alphabetical order, so there is no need to check whether each item actually follows value of control variable.
  • Loading branch information
AndySky21 committed Apr 29, 2015
1 parent c3f7b62 commit 8042414
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions script/room.js
Original file line number Diff line number Diff line change
Expand Up @@ -797,6 +797,7 @@ var Room = {
$SM.set('stores["'+k+'"]', 0);
}

k = _(k);

// thieves?
if(typeof $SM.get('game.thieves') == 'undefined' && num > 5000 && $SM.get('features.location.world')) {
Expand All @@ -805,21 +806,21 @@ var Room = {

if(row.length === 0 && num > 0) {
row = $('<div>').attr('id', id).addClass('storeRow');
$('<div>').addClass('row_key').text(_(k)).appendTo(row);
$('<div>').addClass('row_key').text(k).appendTo(row);
$('<div>').addClass('row_val').text(Math.floor(num)).appendTo(row);
$('<div>').addClass('clear').appendTo(row);
var curPrev = null;
location.children().each(function(i) {
var child = $(this);
var cName = child.attr('id').substring(4).replace('-', ' ');
if(cName < k && (curPrev == null || cName > curPrev)) {
curPrev = cName;
var cName = child.children('.row_key').text();
if(cName < k) {
curPrev = child.attr('id');
}
});
if(curPrev == null) {
row.prependTo(location);
} else {
row.insertAfter(location.find('#row_' + curPrev.replace(' ', '-')));
row.insertAfter(location.find('#' + curPrev));
}
newRow = true;
} else if(num>= 0){
Expand Down

0 comments on commit 8042414

Please sign in to comment.