Skip to content

Commit

Permalink
[ReactNative] Fix warnings w/h => width/height
Browse files Browse the repository at this point in the history
  • Loading branch information
sahrens committed May 2, 2015
1 parent 5e110d2 commit 59997df
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Libraries/Components/ScrollResponder.js
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ var ScrollResponderMixin = {

/**
* A helper function to zoom to a specific rect in the scrollview.
* @param {object} rect Should have shape {x, y, w, h}
* @param {object} rect Should have shape {x, y, width, height}
*/
scrollResponderZoomTo: function(rect: { x: number; y: number; width: number; height: number; }) {
RCTUIManagerDeprecated.zoomToRect(this.getNodeHandle(), rect);
Expand Down
2 changes: 1 addition & 1 deletion Libraries/Components/View/ViewStylePropTypes.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ var ViewStylePropTypes = {
overflow: ReactPropTypes.oneOf(['visible', 'hidden']),
shadowColor: ReactPropTypes.string,
shadowOffset: ReactPropTypes.shape(
{h: ReactPropTypes.number, w: ReactPropTypes.number}
{width: ReactPropTypes.number, height: ReactPropTypes.number}
),
shadowOpacity: ReactPropTypes.number,
shadowRadius: ReactPropTypes.number,
Expand Down
6 changes: 3 additions & 3 deletions Libraries/Utilities/differ/sizesDiffer.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
*/
'use strict';

var dummySize = {w: undefined, h: undefined};
var dummySize = {width: undefined, height: undefined};

var sizesDiffer = function(one, two) {
one = one || dummySize;
two = two || dummySize;
return one !== two && (
one.w !== two.w ||
one.h !== two.h
one.width !== two.width ||
one.height !== two.height
);
};

Expand Down

0 comments on commit 59997df

Please sign in to comment.