Skip to content

Commit

Permalink
[FLINK-8765] [quickstarts] Simplify quickstart properties
Browse files Browse the repository at this point in the history
This does not pull out the slf4j and log4j version into properties any more,
making the quickstarts a bit simpler.

Given that both versions are used only once, and only for the feature to have
convenience logging in the IDE, the versions might as well be defined directly
in the dependencies.
  • Loading branch information
StephanEwen committed Feb 26, 2018
1 parent 51262c8 commit 509f854
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@ under the License.
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<flink.version>@project.version@</flink.version>
<slf4j.version>@slf4j.version@</slf4j.version>
<log4j.version>@log4j.version@</log4j.version>
<scala.binary.version>@scala.binary.version@</scala.binary.version>
</properties>

Expand Down Expand Up @@ -82,13 +80,13 @@ under the License.
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
<version>${slf4j.version}</version>
<version>1.7.7</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
<version>${log4j.version}</version>
<version>1.2.17</version>
<scope>runtime</scope>
</dependency>
</dependencies>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ under the License.
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<flink.version>@project.version@</flink.version>
<slf4j.version>@slf4j.version@</slf4j.version>
<log4j.version>@log4j.version@</log4j.version>
<scala.binary.version>2.11</scala.binary.version>
<scala.version>2.11.12</scala.version>
</properties>
Expand Down Expand Up @@ -92,13 +90,13 @@ under the License.
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-log4j12</artifactId>
<version>${slf4j.version}</version>
<version>1.7.7</version>
<scope>runtime</scope>
</dependency>
<dependency>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
<version>${log4j.version}</version>
<version>1.2.17</version>
<scope>runtime</scope>
</dependency>
</dependencies>
Expand Down

0 comments on commit 509f854

Please sign in to comment.