Skip to content

Commit

Permalink
[FLINK-20808][build] Remove redundant checkstyle rules
Browse files Browse the repository at this point in the history
  • Loading branch information
@zentol
zentol committed Apr 27, 2022
1 parent 95e3a5a commit 5f8fb30
Showing 1 changed file with 0 additions and 102 deletions.
102 changes: 0 additions & 102 deletions tools/maven/checkstyle.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,6 @@ This file is based on the checkstyle file of Apache Beam.

<module name="Checker">

<module name="NewlineAtEndOfFile">
<!-- windows can use \r\n vs \n, so enforce the most used one ie UNIx style -->
<property name="lineSeparator" value="lf"/>
</module>

<module name="RegexpSingleline">
<!-- Checks that TODOs don't have stuff in parenthesis, e.g., username. -->
<property name="format" value="((//.*)|(\*.*))TODO\("/>
Expand Down Expand Up @@ -181,26 +176,6 @@ This file is based on the checkstyle file of Apache Beam.
-->

<module name="RedundantImport">
<!-- Checks for redundant import statements. -->
<property name="severity" value="error"/>
<message key="import.redundancy"
value="Redundant import {0}."/>
</module>

<module name="ImportOrder">
<!-- Checks for out of order import statements. -->
<property name="severity" value="error"/>
<property name="groups"
value="org.apache.flink,org.apache.flink.shaded,*,javax,java,scala"/>
<property name="separated" value="true"/>
<property name="sortStaticImportsAlphabetically" value="true"/>
<property name="option" value="bottom"/>
<property name="tokens" value="STATIC_IMPORT, IMPORT"/>
<message key="import.ordering"
value="Import {0} appears after other imports that it should precede"/>
</module>

<module name="AvoidStarImport">
<property name="severity" value="error"/>
</module>
Expand Down Expand Up @@ -249,13 +224,6 @@ This file is based on the checkstyle file of Apache Beam.
<property name="message" value="Static import functions from Guava Preconditions"/>
</module>

<module name="UnusedImports">
<property name="severity" value="error"/>
<property name="processJavadoc" value="true"/>
<message key="import.unused"
value="Unused import: {0}."/>
</module>

<!--
JAVADOC CHECKS
Expand Down Expand Up @@ -420,21 +388,6 @@ This file is based on the checkstyle file of Apache Beam.
<property name="ignoreComments" value="true"/>
</module>

<!--
MODIFIERS CHECKS
-->

<module name="ModifierOrder">
<!-- Warn if modifier order is inconsistent with JLS3 8.1.1, 8.3.1, and
8.4.3. The prescribed order is:
public, protected, private, abstract, static, final, transient, volatile,
synchronized, native, strictfp
-->
<property name="severity" value="error"/>
</module>


<!--
Expand All @@ -453,61 +406,6 @@ This file is based on the checkstyle file of Apache Beam.
INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF,
CTOR_DEF"/>
</module>

<module name="WhitespaceAround">
<!-- Checks that various tokens are surrounded by whitespace.
This includes most binary operators and keywords followed
by regular or curly braces.
-->
<property name="tokens" value="ASSIGN, BAND, BAND_ASSIGN, BOR,
BOR_ASSIGN, BSR, BSR_ASSIGN, BXOR, BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN,
EQUAL, GE, GT, LAMBDA, LAND, LE, LITERAL_CATCH, LITERAL_DO, LITERAL_ELSE,
LITERAL_FINALLY, LITERAL_FOR, LITERAL_IF, LITERAL_RETURN,
LITERAL_SYNCHRONIZED, LITERAL_TRY, LITERAL_WHILE, LOR, LT, MINUS,
MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ASSIGN, QUESTION,
SL, SL_ASSIGN, SR_ASSIGN, STAR, STAR_ASSIGN, TYPE_EXTENSION_AND"/>
<property name="severity" value="error"/>
</module>

<module name="WhitespaceAfter">
<!-- Checks that commas, semicolons and typecasts are followed by
whitespace.
-->
<property name="tokens" value="COMMA, SEMI, TYPECAST"/>
</module>

<module name="NoWhitespaceAfter">
<!-- Checks that there is no whitespace after various unary operators.
Linebreaks are allowed.
-->
<property name="tokens" value="BNOT, DEC, DOT, INC, LNOT, UNARY_MINUS,
UNARY_PLUS"/>
<property name="allowLineBreaks" value="true"/>
<property name="severity" value="error"/>
</module>

<module name="NoWhitespaceBefore">
<!-- Checks that there is no whitespace before various unary operators.
Linebreaks are allowed.
-->
<property name="tokens" value="SEMI, DOT, POST_DEC, POST_INC"/>
<property name="allowLineBreaks" value="true"/>
<property name="severity" value="error"/>
</module>

<module name="OperatorWrap">
<!-- Checks that assignment operators are at the end of the line. -->
<property name="option" value="eol"/>
<property name="tokens" value="ASSIGN"/>
</module>

<module name="ParenPad">
<!-- Checks that there is no whitespace before close parens or after
open parens.
-->
<property name="severity" value="error"/>
</module>

</module>
</module>

0 comments on commit 5f8fb30

Please sign in to comment.