removed unnecessary transaction

niepeng · Jun 10, 2013 · f5b7e7c · f5b7e7c
1 parent db7b181
commit f5b7e7c
Showing 1 changed file with 41 additions and 49 deletions.
diff --git a/Database/Constants/src/com/commonsware/android/constants/DatabaseHelper.java b/Database/Constants/src/com/commonsware/android/constants/DatabaseHelper.java
@@ -33,69 +33,61 @@ public DatabaseHelper(Context context) {
 
   @Override
   public void onCreate(SQLiteDatabase db) {
-    try {
-      db.beginTransaction();
-      db.execSQL("CREATE TABLE constants (_id INTEGER PRIMARY KEY AUTOINCREMENT, title TEXT, value REAL);");
+    db.execSQL("CREATE TABLE constants (_id INTEGER PRIMARY KEY AUTOINCREMENT, title TEXT, value REAL);");
 
-      ContentValues cv=new ContentValues();
+    ContentValues cv=new ContentValues();
 
-      cv.put(TITLE, "Gravity, Death Star I");
-      cv.put(VALUE, SensorManager.GRAVITY_DEATH_STAR_I);
-      db.insert("constants", TITLE, cv);
+    cv.put(TITLE, "Gravity, Death Star I");
+    cv.put(VALUE, SensorManager.GRAVITY_DEATH_STAR_I);
+    db.insert("constants", TITLE, cv);
 
-      cv.put(TITLE, "Gravity, Earth");
-      cv.put(VALUE, SensorManager.GRAVITY_EARTH);
-      db.insert("constants", TITLE, cv);
+    cv.put(TITLE, "Gravity, Earth");
+    cv.put(VALUE, SensorManager.GRAVITY_EARTH);
+    db.insert("constants", TITLE, cv);
 
-      cv.put(TITLE, "Gravity, Jupiter");
-      cv.put(VALUE, SensorManager.GRAVITY_JUPITER);
-      db.insert("constants", TITLE, cv);
+    cv.put(TITLE, "Gravity, Jupiter");
+    cv.put(VALUE, SensorManager.GRAVITY_JUPITER);
+    db.insert("constants", TITLE, cv);
 
-      cv.put(TITLE, "Gravity, Mars");
-      cv.put(VALUE, SensorManager.GRAVITY_MARS);
-      db.insert("constants", TITLE, cv);
+    cv.put(TITLE, "Gravity, Mars");
+    cv.put(VALUE, SensorManager.GRAVITY_MARS);
+    db.insert("constants", TITLE, cv);
 
-      cv.put(TITLE, "Gravity, Mercury");
-      cv.put(VALUE, SensorManager.GRAVITY_MERCURY);
-      db.insert("constants", TITLE, cv);
+    cv.put(TITLE, "Gravity, Mercury");
+    cv.put(VALUE, SensorManager.GRAVITY_MERCURY);
+    db.insert("constants", TITLE, cv);
 
-      cv.put(TITLE, "Gravity, Moon");
-      cv.put(VALUE, SensorManager.GRAVITY_MOON);
-      db.insert("constants", TITLE, cv);
+    cv.put(TITLE, "Gravity, Moon");
+    cv.put(VALUE, SensorManager.GRAVITY_MOON);
+    db.insert("constants", TITLE, cv);
 
-      cv.put(TITLE, "Gravity, Neptune");
-      cv.put(VALUE, SensorManager.GRAVITY_NEPTUNE);
-      db.insert("constants", TITLE, cv);
+    cv.put(TITLE, "Gravity, Neptune");
+    cv.put(VALUE, SensorManager.GRAVITY_NEPTUNE);
+    db.insert("constants", TITLE, cv);
 
-      cv.put(TITLE, "Gravity, Pluto");
-      cv.put(VALUE, SensorManager.GRAVITY_PLUTO);
-      db.insert("constants", TITLE, cv);
+    cv.put(TITLE, "Gravity, Pluto");
+    cv.put(VALUE, SensorManager.GRAVITY_PLUTO);
+    db.insert("constants", TITLE, cv);
 
-      cv.put(TITLE, "Gravity, Saturn");
-      cv.put(VALUE, SensorManager.GRAVITY_SATURN);
-      db.insert("constants", TITLE, cv);
+    cv.put(TITLE, "Gravity, Saturn");
+    cv.put(VALUE, SensorManager.GRAVITY_SATURN);
+    db.insert("constants", TITLE, cv);
 
-      cv.put(TITLE, "Gravity, Sun");
-      cv.put(VALUE, SensorManager.GRAVITY_SUN);
-      db.insert("constants", TITLE, cv);
+    cv.put(TITLE, "Gravity, Sun");
+    cv.put(VALUE, SensorManager.GRAVITY_SUN);
+    db.insert("constants", TITLE, cv);
 
-      cv.put(TITLE, "Gravity, The Island");
-      cv.put(VALUE, SensorManager.GRAVITY_THE_ISLAND);
-      db.insert("constants", TITLE, cv);
+    cv.put(TITLE, "Gravity, The Island");
+    cv.put(VALUE, SensorManager.GRAVITY_THE_ISLAND);
+    db.insert("constants", TITLE, cv);
 
-      cv.put(TITLE, "Gravity, Uranus");
-      cv.put(VALUE, SensorManager.GRAVITY_URANUS);
-      db.insert("constants", TITLE, cv);
+    cv.put(TITLE, "Gravity, Uranus");
+    cv.put(VALUE, SensorManager.GRAVITY_URANUS);
+    db.insert("constants", TITLE, cv);
 
-      cv.put(TITLE, "Gravity, Venus");
-      cv.put(VALUE, SensorManager.GRAVITY_VENUS);
-      db.insert("constants", TITLE, cv);
-
-      db.setTransactionSuccessful();
-    }
-    finally {
-      db.endTransaction();
-    }
+    cv.put(TITLE, "Gravity, Venus");
+    cv.put(VALUE, SensorManager.GRAVITY_VENUS);
+    db.insert("constants", TITLE, cv);
   }
 
   @Override