-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust tests to PHPUnit 10 #998
Conversation
Is this necessary? Doesn't PHPUnit automatically migrate the old config? |
XML of PHPUnit v10 is not compatible with XML of PHPUnit v9. Joining it with strictness of warnings it's not possible to use the same PHPUnit configuration file for both versions of 9 and 10. Example of failing test with PHPUnit 10 but with elements of XML from PHPUnit 9: https://github.com/nikic/PHP-Parser/actions/runs/9086446408/job/24979454495?pr=998 The idea I came up with is to have simply two configuration files for each PHPUnit version. The other solution would be to upgrade completely to PHPUnit 10, but it would require bumping min. PHP version to 8.1 which is not desired for now. |
58c3356
to
26320c4
Compare
I think overall I'm not clear on what the benefit of using PHPUnit 10 on some versions and PHPUnit 9 on some is. This just seems to increase complexity, as we wouldn't be able to use any new functionality from PHPUnit 10 anyway. If it "just worked", that would be one thing, but apparently it doesn't... (I think merging just the data provide changes would make sense though, in the interest of forward-compatibility.) |
That makes sense. I left the code preparing codebase for the PHPUnit upgrade, but it needs to wait for a bump of a minimum PHP version to 8.1. |
a4fbe98
to
402f714
Compare
Prepares codebase to PHPUnit 10.
phpunit.xml.9.5.dist
Following changes have been reverted from the PR:
^10.0
in Composer,.gitignore
,