update(query): improved "Resource Not Using Tags" description (Checkm…

…arx#5483) * updated "Resource Not Using Tags" description * fixing E2E test
nikitakoselev · Jun 21, 2022 · af958ea · af958ea
1 parent 3ab1ca4
commit af958ea
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/assets/queries/terraform/aws/resource_not_using_tags/metadata.json b/assets/queries/terraform/aws/resource_not_using_tags/metadata.json
@@ -3,7 +3,7 @@
   "queryName": "Resource Not Using Tags",
   "severity": "INFO",
   "category": "Best Practices",
-  "descriptionText": "AWS services resource tags are an essential part of managing components",
+  "descriptionText": "AWS services resource tags are an essential part of managing components. As a best practice, the field 'tags' should have additional tags defined other than 'Name'",
   "descriptionUrl": "https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/resource-tagging",
   "platform": "Terraform",
   "descriptionID": "09db2d52",

diff --git a/assets/queries/terraform/aws/resource_not_using_tags/query.rego b/assets/queries/terraform/aws/resource_not_using_tags/query.rego
@@ -34,8 +34,8 @@ CxPolicy[result] {
 		"resourceName": tf_lib.get_resource_name(resource, name),
 		"searchKey": sprintf("%s[{{%s}}].tags", [res, name]),
 		"issueType": "MissingAttribute",
-		"keyExpectedValue": sprintf("%s[{{%s}}].tags has tags defined other than 'Name'", [res, name]),
-		"keyActualValue": sprintf("%s[{{%s}}].tags has no tags defined", [res, name]),
+		"keyExpectedValue": sprintf("%s[{{%s}}].tags has additional tags defined other than 'Name'", [res, name]),
+		"keyActualValue": sprintf("%s[{{%s}}].tags does not have additional tags defined other than 'Name'", [res, name]),
 	}
 }
 

diff --git a/e2e/fixtures/E2E_CLI_033_RESULT.json b/e2e/fixtures/E2E_CLI_033_RESULT.json
@@ -149,7 +149,7 @@
 			"platform": "Terraform",
 			"cloud_provider": "AWS",
 			"category": "Best Practices",
-			"description": "AWS services resource tags are an essential part of managing components",
+			"description": "AWS services resource tags are an essential part of managing components. As a best practice, the field 'tags' should have additional tags defined other than 'Name'",
 			"description_id": "09db2d52",
 			"files": [
 				{