Addressing CR comments from Mark

nikoma · May 18, 2016 · 67d21fa · 67d21fa
1 parent 60424db
commit 67d21fa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/Source/Readers/ImageReader/ImageDataDeserializer.cpp b/Source/Readers/ImageReader/ImageDataDeserializer.cpp
@@ -119,8 +119,6 @@ class ImageDataDeserializer::ImageChunk : public Chunk, public std::enable_share
 
 // A new constructor to support new compositional configuration,
 // that allows composition of deserializers and transforms on inputs.
-// For a sample config please see AlexImage end-to-end test.
-// TODO: Provide only sequences specified in the corpus descriptor.
 ImageDataDeserializer::ImageDataDeserializer(CorpusDescriptorPtr corpus, const ConfigParameters& config)
 {
     ConfigParameters inputs = config("input");

diff --git a/Source/Readers/ReaderLib/Bundler.cpp b/Source/Readers/ReaderLib/Bundler.cpp
@@ -133,10 +133,8 @@ void Bundler::GetSequencesForChunk(size_t chunkId, std::vector<SequenceDescripti
     // Can return because all sequences are clean.
     if (chunk->m_invalid.empty())
     {
-        // Reindexing.
-        // TODO: This should be done on the level of deserializer, currently CNTKTextFormat
-        // TODO: exposes not sequencetion ids.
-        for (int i = 0; i < sequences.size(); ++i)
+        // Reindexing, because currently m_ids provided by some deserializers (i.e. CNTKTextFormat) are not contiguous.
+        for (size_t i = 0; i < sequences.size(); ++i)
         {
             sequences[i].m_id = i;
         }