Preserve an offline-saved model's temporary id when updated offline

Fixes #145

CHANGES.md

@@ -1,3 +1,7 @@
+### master / unreleased
+
+* Fix #145: Prevent model's id from being nulled (and saved locally with that id) when an offlineStatusCode is returned; broken since 1.4.0
+
 ### 1.4.0 / 2015-02-16
 
 * Fix #123: Expose original BackboneSync as Backbone.DualStorage.originalSync to allow custom online sync methods (Richard Tibbles)

backbone.dualstorage.coffee

@@ -332,9 +332,9 @@ dualsync = (method, model, options) ->
         temporaryId = model.id
 
         options.success = (resp, _status, _xhr) ->
+          model.set model.idAttribute, temporaryId, silent: true
           return useOfflineStorage() if hasOfflineStatusCode options.xhr
           updatedModel = modelUpdatedWithResponse model, resp
-          model.set model.idAttribute, temporaryId, silent: true
           localsync('delete', model, options)
           localsync('create', updatedModel, options)
           success(resp, _status, _xhr)

spec/dualsync_spec.coffee

@@ -251,6 +251,17 @@ describe 'offline storage', ->
       expect(localsync.calls.length).toEqual 1
       expect(localsync.calls[0].args[2].dirty).toBeTruthy()
 
+  it "preserves an offline-saved model's temporary id when updated offline", ->
+    ready = undefined
+    temporaryId = 'tttttttttttttttttttttttttttttttttttt'
+    runs ->
+      ready = false
+      model.set model.idAttribute, temporaryId
+      dualsync('update', model, success: (-> ready = true), successStatus: 0)
+    waitsFor (-> ready), "The success callback should have been called", 100
+    runs ->
+      expect(model.id).toEqual temporaryId
+
 describe 'dualStorage hooks', ->
   beforeEach ->
     model.parseBeforeLocalSave = ->

spec/spec_helper.coffee

@@ -5,8 +5,10 @@ window.Backbone.sync = jasmine.createSpy('sync').andCallFake (method, model, opt
   callback = options.success
   xhr = {status: status, response: resp}
   if typeof options.errorStatus is 'number'
-    resp.status = status = options.errorStatus
+    resp.status = xhr.status = status = options.errorStatus
     callback = options.error
+  if typeof options.successStatus is 'number'
+    resp.status = xhr.status = status = options.successStatus
   if Backbone.VERSION == '0.9.10'
     callback(model, resp, options)
   else if Backbone.VERSION[0] == '0'