MDL-58578 mod_quiz: Correctly provide group override priorities

Previously the override priorities were being provided
back to front.

mod/quiz/lib.php

@@ -1352,17 +1352,17 @@ function quiz_get_group_override_priorities($quizid) {
         }
     }
 
-    // Sort open times in descending manner. The earlier open time gets higher priority.
-    rsort($grouptimeopen);
+    // Sort open times in ascending manner. The earlier open time gets higher priority.
+    sort($grouptimeopen);
     // Set priorities.
     $opengrouppriorities = [];
     $openpriority = 1;
     foreach ($grouptimeopen as $timeopen) {
         $opengrouppriorities[$timeopen] = $openpriority++;
     }
 
-    // Sort close times in ascending manner. The later close time gets higher priority.
-    sort($grouptimeclose);
+    // Sort close times in descending manner. The later close time gets higher priority.
+    rsort($grouptimeclose);
     // Set priorities.
     $closegrouppriorities = [];
     $closepriority = 1;

mod/quiz/tests/lib_test.php

@@ -489,13 +489,13 @@ public function test_quiz_get_group_override_priorities() {
 
         $openpriorities = $priorities['open'];
         // Override 2's time open has higher priority since it is sooner than override 1's.
-        $this->assertEquals(1, $openpriorities[$override1->timeopen]);
-        $this->assertEquals(2, $openpriorities[$override2->timeopen]);
+        $this->assertEquals(2, $openpriorities[$override1->timeopen]);
+        $this->assertEquals(1, $openpriorities[$override2->timeopen]);
 
         $closepriorities = $priorities['close'];
         // Override 1's time close has higher priority since it is later than override 2's.
-        $this->assertEquals(2, $closepriorities[$override1->timeclose]);
-        $this->assertEquals(1, $closepriorities[$override2->timeclose]);
+        $this->assertEquals(1, $closepriorities[$override1->timeclose]);
+        $this->assertEquals(2, $closepriorities[$override2->timeclose]);
     }
 
     public function test_quiz_core_calendar_provide_event_action_open() {