Skip to content

Commit

Permalink
MDL-28032 database - fix some sign inconsistencies
Browse files Browse the repository at this point in the history
  • Loading branch information
stronk7 committed Jun 26, 2011
1 parent d466e23 commit a0628c6
Show file tree
Hide file tree
Showing 4 changed files with 30 additions and 2 deletions.
14 changes: 14 additions & 0 deletions lib/db/upgrade.php
Original file line number Diff line number Diff line change
Expand Up @@ -6558,6 +6558,20 @@ function xmldb_main_upgrade($oldversion) {
upgrade_main_savepoint(true, 2011062000.01);
}

// Signed fixes - MDL-28032
if ($oldversion < 2011062400.01) {

// Changing sign of field defaultmark on table question to unsigned
$table = new xmldb_table('question');
$field = new xmldb_field('defaultmark', XMLDB_TYPE_NUMBER, '12, 7', XMLDB_UNSIGNED, XMLDB_NOTNULL, null, '1', 'generalfeedbackformat');

// Launch change of sign for field defaultmark
$dbman->change_field_unsigned($table, $field);

// Main savepoint reached
upgrade_main_savepoint(true, 2011062400.01);
}

return true;
}

Expand Down
14 changes: 14 additions & 0 deletions mod/quiz/report/statistics/db/upgrade.php
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,20 @@ function xmldb_quiz_statistics_upgrade($oldversion) {
upgrade_plugin_savepoint(true, 2011021500, 'quiz', 'statistics');
}

// Signed fixes - MDL-28032
if ($oldversion < 2011062600) {

// Changing sign of field maxmark on table quiz_question_statistics to signed
$table = new xmldb_table('quiz_question_statistics');
$field = new xmldb_field('maxmark', XMLDB_TYPE_NUMBER, '12, 7', null, null, null, null, 'subquestions');

// Launch change of sign for field maxmark
$dbman->change_field_unsigned($table, $field);

// statistics savepoint reached
upgrade_plugin_savepoint(true, 2011062600, 'quiz', 'statistics');
}

return true;
}

2 changes: 1 addition & 1 deletion mod/quiz/report/statistics/version.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,5 +25,5 @@

defined('MOODLE_INTERNAL') || die();

$plugin->version = 2011051200;
$plugin->version = 2011062600;
$plugin->requires = 2011060313;
2 changes: 1 addition & 1 deletion version.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@



$version = 2011062400.00; // YYYYMMDD = weekly release date of this DEV branch
$version = 2011062400.01; // YYYYMMDD = weekly release date of this DEV branch
// RR = release increments - 00 in DEV branches
// .XX = incremental changes

Expand Down

0 comments on commit a0628c6

Please sign in to comment.