Skip to content

Commit

Permalink
MDL-28196 quiz calls get_in_or_equal (not DB->get_in_or_equal) in two…
Browse files Browse the repository at this point in the history
… places

Also, another minor error in one method call.
  • Loading branch information
timhunt committed Jul 5, 2011
1 parent 81f8e0f commit b149b78
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion mod/quiz/report/overview/overview_table.php
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public function build_table() {
$namekey => get_string('groupavg', 'grades'),
'sumgrades' => $this->format_average($record),
'feedbacktext'=> strip_tags(quiz_report_feedback_for_grade(
$record->grade, $this->quiz->id)));
$record->grade, $this->quiz->id, $this->context)));
if ($this->detailedmarks && ($this->quiz->attempts == 1 || $this->qmsubselect)) {
$avggradebyq = $this->load_average_question_grades($this->groupstudents);
$groupaveragerow += $this->format_average_grade_for_questions($avggradebyq);
Expand Down
2 changes: 1 addition & 1 deletion mod/quiz/report/overview/report.php
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ protected function count_question_attempts_needing_regrade($quiz, $groupstudents
$usertest = '';
$params = array();
if ($groupstudents) {
list($usql, $params) = get_in_or_equal($groupstudents);
list($usql, $params) = $DB->get_in_or_equal($groupstudents);
$usertest = "quiza.userid $usql AND ";
}

Expand Down
2 changes: 1 addition & 1 deletion mod/quiz/report/statistics/report.php
Original file line number Diff line number Diff line change
Expand Up @@ -1047,7 +1047,7 @@ function quiz_statistics_attempts_sql($quizid, $currentgroup, $groupstudents,
$qaparams = array('quizid' => $quizid);

if (!empty($currentgroup) && $groupstudents) {
list($grpsql, $grpparams) = get_in_or_equal(array_keys($groupstudents),
list($grpsql, $grpparams) = $DB->get_in_or_equal(array_keys($groupstudents),
SQL_PARAMS_NAMED, 'u');
$whereqa .= " AND quiza.userid $grpsql";
$qaparams += $grpparams;
Expand Down

0 comments on commit b149b78

Please sign in to comment.