Skip to content

Commit

Permalink
eth: Adjust ENC28J60 MAC configuration.
Browse files Browse the repository at this point in the history
ENCC28J60 specs section 6.5 "MAC Initialization settings"
state that MACON3(7:5) register configure automatic padding and CRC.
It also states that the configuration 111 and 011 both configure as
all short frames to be zero padded with a valid CRC appended.

Nevertheless, experimentally, there are ocassions when configuring as 111
frames does not have a CRC appended. This frames could be rejected
by the receiver if it is configured to do so.

This commit changes configuration from 111 to 011, which is not
presenting that behavior.

Jira: ZEP-842

Change-Id: I302bb99f7a1f23b298fe0db0245963b640644040
Signed-off-by: Juan Manuel Cruz <[email protected]>
  • Loading branch information
jmnlcruz authored and Anas Nashif committed Sep 17, 2016
1 parent 69d4f2a commit 8da0bad
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/ethernet/eth_enc28j60_priv.h
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@
* - Automatic CRC
* - Frame Length Checking
*/
#define ENC28J60_MAC_CONFIG 0xF2
#define ENC28J60_MAC_CONFIG 0x32
#define ENC28J60_MAC_BBIPG_HD 0x12
#define ENC28J60_MAC_BBIPG_FD 0x15
#define ENC28J60_MAC_NBBIPGL 0x12
Expand Down

0 comments on commit 8da0bad

Please sign in to comment.