Skip to content

Commit

Permalink
[firebase_crashlytics] No need for async as there's no await (firebas…
Browse files Browse the repository at this point in the history
…e#1561)

* No need for async as there's no await

* Update CHANGELOG.md

* Update pubspec.yaml
  • Loading branch information
feinstein authored and collinjackson committed Dec 5, 2019
1 parent a688c76 commit 137a354
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions packages/firebase_crashlytics/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.1.2+2

* Removed the `async` from the `runZoned()` in the example, as there's no `await` to be executed.

## 0.1.2+1

* Updated a confusing comment.
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_crashlytics/example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ void main() {
// Pass all uncaught errors to Crashlytics.
FlutterError.onError = Crashlytics.instance.recordFlutterError;

runZoned<Future<void>>(() async {
runZoned<Future<void>>(() {
runApp(MyApp());
}, onError: Crashlytics.instance.recordError);
}
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_crashlytics/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: firebase_crashlytics
description:
Flutter plugin for Firebase Crashlytics. It reports uncaught errors to the
Firebase console.
version: 0.1.2+1
version: 0.1.2+2
author: Flutter Team <[email protected]>
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_crashlytics

Expand Down

0 comments on commit 137a354

Please sign in to comment.