Skip to content

Commit

Permalink
[Narwhal] Do not retry InvalidEpoch error (MystenLabs#7129)
Browse files Browse the repository at this point in the history
This does not fix the InvalidEpoch errors, but just something I found
while reading code.

An invalid epoch response is not retriable at the RPC layer, or even at
the level of Narwhal.

In future, maybe we can refactor to assume an error is not retriable by
default.
  • Loading branch information
mwtian authored Jan 4, 2023
1 parent 979288b commit 76215bd
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions narwhal/primary/src/primary.rs
Original file line number Diff line number Diff line change
Expand Up @@ -901,6 +901,7 @@ impl PrimaryToPrimary for PrimaryReceiverHandler {
match e {
// Report unretriable errors as 400 Bad Request.
DagError::InvalidSignature
| DagError::InvalidEpoch { .. }
| DagError::InvalidHeaderDigest
| DagError::HeaderHasBadWorkerIds(_)
| DagError::HeaderHasInvalidParentRoundNumbers(_)
Expand Down

0 comments on commit 76215bd

Please sign in to comment.